Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with latest changes in arm core #1301

Closed
wants to merge 1 commit into from
Closed

Align with latest changes in arm core #1301

wants to merge 1 commit into from

Conversation

ArcturusZhang
Copy link
Member

Description

Align the code generator with recent changes in Azure.ResourceManager.Core

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang requested a review from isra-fel June 8, 2021 05:14
@ArcturusZhang ArcturusZhang force-pushed the align-with-latest-armcore branch from 74974e7 to c4ad740 Compare June 8, 2021 06:06
@ArcturusZhang ArcturusZhang marked this pull request as draft June 8, 2021 07:06
@ArcturusZhang ArcturusZhang force-pushed the align-with-latest-armcore branch from c4ad740 to a19e222 Compare June 8, 2021 11:33
@ArcturusZhang ArcturusZhang marked this pull request as ready for review June 8, 2021 12:47
chamons
chamons reviewed Jun 8, 2021
View reviewed changes
Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very few code changes, almost all csproj. Here's the tl-dr diff - https://gist.github.com/chamons/c3fc5020b4f8a404c681676953c9be02

Approved from a shared code angle.

@isra-fel
Copy link
Member

isra-fel commented Jun 8, 2021

Closing this in favor of #1302

@isra-fel isra-fel closed this Jun 8, 2021
@ArcturusZhang ArcturusZhang deleted the align-with-latest-armcore branch June 9, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chamons chamons chamons left review comments

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@m-nash m-nash Awaiting requested review from m-nash

@pakrym pakrym Awaiting requested review from pakrym

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja

@isra-fel isra-fel Awaiting requested review from isra-fel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArcturusZhang @isra-fel @chamons