Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(http-client-csharp): remove filter-out-core-models option #5160

Merged
merged 2 commits into from
Nov 14, 2024
Merged

refactor(http-client-csharp): remove filter-out-core-models option #5160

merged 2 commits into from
Nov 14, 2024

Conversation

archerzz
Copy link
Member

Description

No code change is required in autorest.csharp.

resolve microsoft/typespec#5109

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@azure-sdk azure-sdk mentioned this pull request Nov 14, 2024
Closed
@archerzz
Copy link
Member Author

regen preview: Azure/azure-sdk-for-net#47149

no code change

@archerzz archerzz enabled auto-merge (squash) November 14, 2024 08:57
@archerzz archerzz merged commit 9106ee0 into Azure:main Nov 14, 2024
8 checks passed
@archerzz archerzz deleted the remove-filter-out-core-models branch November 14, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunyu3 chunyu3 chunyu3 approved these changes

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[http-client-csharp]: remove filter-out-core-models
2 participants
@archerzz @chunyu3