Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Allow binary files with json content type #363

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Dec 3, 2020

fix Azure/autorest#3714
fix Azure/autorest#3631

Comparaison of model before(left) and after(right)
image

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


add --use: to the command line:

autorest --use:https://tinyurl.com/y6m9e5bl ...


or use the following in your autorest configuration:

use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/y6m9e5bl" 

If this build is good for you, give this comment a thumbs up. (👍)

And you should run autorest --reset again once you're finished testing to remove it.

@Azure Azure deleted a comment from azure-pipelines bot Dec 3, 2020
@daviwil
Copy link
Contributor

daviwil commented Dec 3, 2020

@iscai-msft - When you have a moment can you give the build above a try to see if it resolves the issue you reported? Thanks!

Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! We can merge it after Isabella confirms the fix.

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


add --use: to the command line:

autorest --use:https://tinyurl.com/y4d3ej3w ...


or use the following in your autorest configuration:

use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/y4d3ej3w" 

If this build is good for you, give this comment a thumbs up. (👍)

And you should run autorest --reset again once you're finished testing to remove it.

@daviwil
Copy link
Contributor

daviwil commented Dec 3, 2020

I feel pretty sure this fix will work so I'm going to go ahead and merge it. If we need to fix some more things related to it, we can do it in a different PR.

@daviwil daviwil merged commit 8024c8d into master Dec 3, 2020
@timotheeguerin timotheeguerin deleted the feature/allow-binary-file-with-json-content-type branch December 3, 2020 23:02
@iscai-msft
Copy link

thank you so so much @timotheeguerin and @daviwil ! It looks good to me, @tasherif-msft for final confirmation

@iscai-msft
Copy link

@tasherif-msft has also confirmed the fix worked!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants