Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Add a new Always create accept flag #366

Merged
merged 6 commits into from
Dec 4, 2020

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Dec 4, 2020

fix Azure/autorest#3720

This PR also adds typing for the modelerfour options.

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


add --use: to the command line:

autorest --use:https://tinyurl.com/yyz23ubn ...


or use the following in your autorest configuration:

use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/yyz23ubn" 

If this build is good for you, give this comment a thumbs up. (👍)

And you should run autorest --reset again once you're finished testing to remove it.

@timotheeguerin
Copy link
Member Author

Does this not make it a breaking change for generated sdks?

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


add --use: to the command line:

autorest --use:https://tinyurl.com/y5x74fl4 ...


or use the following in your autorest configuration:

use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/y5x74fl4" 

If this build is good for you, give this comment a thumbs up. (👍)

And you should run autorest --reset again once you're finished testing to remove it.

"resolve-schema-name-collisons"?: boolean;
}

export interface ModelerFourNamingOptions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


add --use: to the command line:

autorest --use:https://tinyurl.com/y63hwt6r ...


or use the following in your autorest configuration:

use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/y63hwt6r" 

If this build is good for you, give this comment a thumbs up. (👍)

And you should run autorest --reset again once you're finished testing to remove it.

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


add --use: to the command line:

autorest --use:https://tinyurl.com/y3m4ehsx ...


or use the following in your autorest configuration:

use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/y3m4ehsx" 

If this build is good for you, give this comment a thumbs up. (👍)

And you should run autorest --reset again once you're finished testing to remove it.

@timotheeguerin timotheeguerin merged commit 5a2678d into master Dec 4, 2020
@timotheeguerin timotheeguerin deleted the feature/accept-header-flag branch December 4, 2020 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add modelerfour parameter to control whether Accept header parameter is generated
2 participants