Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Fix: Issue with prenamer renaming to already used values #374

Merged
merged 5 commits into from
Dec 14, 2020

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Dec 10, 2020

When a name was containing duplicate consecutive words it was removing the duplicates but the target name could have already been used. So it will only do that if it is not being used yet.

  • A little cleanup and reoganization of prenamer

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


add --use: to the command line:

autorest --use:https://tinyurl.com/yx97u8t5 ...


or use the following in your autorest configuration:

use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/yx97u8t5" 

If this build is good for you, give this comment a thumbs up. (👍)

And you should run autorest --reset again once you're finished testing to remove it.

@Azure Azure deleted a comment from azure-pipelines bot Dec 10, 2020
@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


add --use: to the command line:

autorest --use:https://tinyurl.com/yygyhf6x ...


or use the following in your autorest configuration:

use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/yygyhf6x" 

If this build is good for you, give this comment a thumbs up. (👍)

And you should run autorest --reset again once you're finished testing to remove it.

Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


add --use: to the command line:

autorest --use:https://tinyurl.com/y3o7oych ...


or use the following in your autorest configuration:

use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/y3o7oych" 

If this build is good for you, give this comment a thumbs up. (👍)

And you should run autorest --reset again once you're finished testing to remove it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants