Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Package mode] add new flag
--package-mode
#1154[Package mode] add new flag
--package-mode
#1154Changes from 5 commits
c11542f
1d5f306
a330b23
7fb023d
e16267f
27df09c
ca60360
0a294f7
eb42ea4
c5c8203
f4a6134
575071f
47e131b
653c253
e54afe0
c302e25
52ac6dc
15349fa
460d2a2
3a9ada9
8dc3cfb
ba4ace6
ae59026
158fdc4
482c0b8
8c426f0
e20e50e
7f45e93
25d5cb5
4705474
a14b58c
b54e494
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it just be
not in ("mgmtplane", "dataplane")
? Not sure whyNone
is a valid entryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Path(None).exist()
will raise exception so we have to avoid that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't really do None checks for any other flag, it's still a little weird because it looks like we're making
None
a valid entry (by including it with mgmtplane and dataplane)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could check None first and it will make the logic more clear