dpg service-driven-test #1180
Merged
dpg service-driven-test #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changlong-liu
force-pushed
the
20220307-service-driven-test
branch
from
d365fdc
to
0babde6
Compare
iscai-msft
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
this looks really good! however, I don't know why but it's not updating in the dashboard (the other DPG tests show up there). Can you double check that you're hitting all of the correct endpoints for each of the cases? Here is the testserver file, I'll double check on my end to see what's going on. Thanks!
|
|
||
| request = params_update_one.build_get_new_operation_request() | ||
| response = await update_one_send_request(request) | ||
| assert response.content.decode('utf8') == json.dumps( |
There was a problem hiding this comment.
nit: you can just do assert response.json() == {'message': 'An object was successfully returned'}
iscai-msft
added a commit
that referenced
this pull request
Mar 9, 2022
…into inherit_customization * 'autorestv3' of https://github.com/Azure/autorest.python: dpg service-driven-test (#1180) prepare for release (#1181) [Package mode] add new flag `--package-mode` (#1154) hide operation group docs (#1179)
iscai-msft
added a commit
that referenced
this pull request
Mar 10, 2022
…into mypy_code * 'autorestv3' of https://github.com/Azure/autorest.python: (26 commits) dpg service-driven-test (#1180) prepare for release (#1181) [Package mode] add new flag `--package-mode` (#1154) hide operation group docs (#1179) add coverage var (#1178) improve logging (#1177) don't reformat query params for dpg next link calls (#1168) Update package.json Update ChangeLog.md default optional const parameter to none (#1171) add storage to ci checks (#1176) fail on regeneration diff (#1173) Drop Python 2.7 (#1175) Add secrets test (#1174) bump testserver version (#1172) make content type keyword only if multiple (#1167) add default value info for params to docs (#1164) update release tests to hopefully get coverage report green (#1152) fix windows: clean the outputFolderUri (#1135) Update CODEOWNERS ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1163.
The report-dpg.json result of this PR: