LLC #875
LLC #875
Conversation
…into prepare_request * 'autorestv3' of https://github.com/Azure/autorest.python: regen and move code model specific args to metadata.json (#867)
…into prepare_request * 'autorestv3' of https://github.com/Azure/autorest.python: Catch deserialize error (#870)
| @@ -47,9 +47,43 @@ def __init__(self, client, config, serializer, deserializer) -> None: | |||
| self._deserialize = deserializer | |||
| self._config = config | |||
|
|
|||
| def _post_required_request( | |||
| self, path: str, body: int, custom_header: Optional[str] = None, query: Optional[int] = 30, **kwargs: Any | |||
There was a problem hiding this comment.
for parameter grouping, I'm ungrouping in the high level operation, and not passing the grouped model to the request.
designed this way bc imo llc is about removing models etc, didn't seem right to have users construct a model to pass to the request.
additionally, in the high level operation, the ungrouped parameters are all private (i.e. _path). Making them public for the request.
question of "what if users have a param called path, and and the grouped model input has a property also called path. Then, we would need to do some name padding for the ungrouped path parameter. Need to look more into whether this beahvior is allowed for users as well
| @@ -558,39 +685,16 @@ async def put_simple_product_with_grouping( | |||
| _max_product_display_name = flatten_parameter_group.max_product_display_name | |||
| _generic_value = flatten_parameter_group.generic_value | |||
| _odata_value = flatten_parameter_group.odata_value | |||
|
|
|||
| _simple_body_product = _models.SimpleProduct( | |||
| _body = _models.SimpleProduct( | |||
There was a problem hiding this comment.
flattening + grouping
| @@ -481,18 +595,45 @@ async def post_flattened_simple_product( | |||
| error_map = {401: ClientAuthenticationError, 404: ResourceNotFoundError, 409: ResourceExistsError} | |||
| error_map.update(kwargs.pop("error_map", {})) | |||
|
|
|||
| _simple_body_product = _models.SimpleProduct( | |||
| _body = _models.SimpleProduct( | |||
…into prepare_request * 'autorestv3' of https://github.com/Azure/autorest.python: fix case of grouped parameter + reserved property name (#970) remove all hosts from global parameters (#972)
|
/azp run autorest.python - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…into fix_credential_ordering * 'autorestv3' of https://github.com/Azure/autorest.python: LLC (#875)
No description provided.