Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through program exit code when using start-autorest-express #240

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Nov 19, 2020

This change updates the start-autorest-express script so that the exit code of the program it wraps will be used as this script's own exit code when it exits. This fixes an issue that was causing the AutoRest Swift repo's CI to report success even though there were errors while running its tests.

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @daviwil!

@daviwil daviwil merged commit 201ab45 into Azure:master Nov 19, 2020
iscai-msft added a commit that referenced this pull request Nov 24, 2020
…into multiapi_diff_signatures

* 'master' of https://github.com/Azure/autorest.testserver:
  Pass through program exit code when using start-autorest-express (#240)
  fix value retval (#237)
  add test for error deserialization in op with param name 'models' (#234)
  add test for first response no items, second response with items (#235)
  bump version after failing to in no op swagger addition (#231)
  add swagger for no operations (#230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants