Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle circular dependency in additionalProperties #3819

Merged
merged 4 commits into from
Feb 1, 2021

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jan 29, 2021

fix #3818

Contrary to how the properties of an object where handled for additionalProperties we weren't caching the current schema before recursing into the type
Todo:

  • Add tests

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/y2l9yo47 For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/y2vzj4us For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/y2l9yo47 --use:https://tinyurl.com/y2vzj4us

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/y2l9yo47"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/y2vzj4us"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@Azure Azure deleted a comment from azure-pipelines bot Jan 29, 2021
@timotheeguerin timotheeguerin merged commit e765f8b into master Feb 1, 2021
@timotheeguerin timotheeguerin deleted the fix/additional-props-circular-dep branch February 1, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autorest(modelerfour) doesn't handle circular dependencies in additionalProperties
2 participants