Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow x-ms-paths not to start with / #4152

Merged
merged 5 commits into from
Jun 4, 2021

Conversation

timotheeguerin
Copy link
Member

No description provided.

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/y56c4t9r For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/yx9ajwd9 For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/y56c4t9r --use:https://tinyurl.com/yx9ajwd9

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/y56c4t9r"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/yx9ajwd9"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

kasobol-msft added a commit to kasobol-msft/azure-sdk-for-net that referenced this pull request Jun 2, 2021
@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/yyt366ql For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/y4smwt45 For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/yyt366ql --use:https://tinyurl.com/y4smwt45

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/yyt366ql"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/y4smwt45"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

Copy link

@kasobol-msft kasobol-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works pretty well here Azure/azure-sdk-for-net#21424

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/y65br49u For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/y4nbbrsk For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/y65br49u --use:https://tinyurl.com/y4nbbrsk

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/y65br49u"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/y4nbbrsk"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@timotheeguerin timotheeguerin merged commit cc9a25e into main Jun 4, 2021
@timotheeguerin timotheeguerin deleted the feat/x-ms-paths-allow-slash branch June 4, 2021 15:32
kasobol-msft added a commit to Azure/azure-sdk-for-net that referenced this pull request Jun 5, 2021
* this gets allocations in line. but isn't great.

* temporarily disable the probe.

* try Azure/autorest#4152

* Revert "temporarily disable the probe."

This reverts commit f5d1587.

* fix empty path.

* mocking.

* fix 403.

* I really dislike url-encoding...

* private protected. nice.

* fix tests.

* datalake.

* fix that.

* shares.

* queues

* batch.

* this works.

* this works. too.
mikeharder added a commit to mikeharder/autorest that referenced this pull request Mar 25, 2024
mikeharder added a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants