Add validation for az webapp scale (#6756)

Azure · Sep 15, 2023 · 1d77264 · 1d77264
1 parent ca53b85
commit 1d77264
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -150,7 +150,7 @@
 
 /src/kusto/ @ilayr @orhasban @astauben
 
-/src/appservice-kube/ @ebencarek @calcha @StrawnSC
+/src/appservice-kube/ @ebencarek @howang-ms @Juliehzl @LaylaLiu-gmail 
 
 /src/custom-providers/ @jsntcy
 

diff --git a/src/appservice-kube/HISTORY.rst b/src/appservice-kube/HISTORY.rst
@@ -2,6 +2,10 @@
 
 Release History
 ===============
+0.1.9
+++++++
+* `az webapp scale`: Add validation to reject non-arc enabled app service
+
 0.1.8
 ++++++
 * Fix appservice kube - No module named 'azure.mgmt.web.v2021_01_01'

diff --git a/src/appservice-kube/azext_appservice_kube/_help.py b/src/appservice-kube/azext_appservice_kube/_help.py
@@ -9,7 +9,7 @@
 
 helps['webapp scale'] = """
 type: command
-short-summary: Modify the number of instances of a webapp.
+short-summary: Modify the number of instances of a webapp on Arc enabled Kubernetes workloads .
 examples:
   - name: Change the number of instances of MyApp to 2.
     text: >

diff --git a/src/appservice-kube/azext_appservice_kube/custom.py b/src/appservice-kube/azext_appservice_kube/custom.py
@@ -981,6 +981,10 @@ def set_webapp(cmd, resource_group_name, name, slot=None, **kwargs):  # pylint:
 
 
 def scale_webapp(cmd, resource_group_name, name, instance_count, slot=None):
+    client = web_client_factory(cmd.cli_ctx)
+    webapp = client.web_apps.get(resource_group_name, name)
+    if not webapp.extended_location:
+        raise ValidationError("The web app {} is not on Arc enabled Kubernetes. Please use `az appservice plan update` to scale for non-arc enabled app service.".format(name))
     return update_site_configs(cmd, resource_group_name, name,
                                number_of_workers=instance_count, slot=slot)
 

diff --git a/src/appservice-kube/setup.py b/src/appservice-kube/setup.py
@@ -16,7 +16,7 @@
 
 # TODO: Confirm this is the right version number you want and it matches your
 # HISTORY.rst entry.
-VERSION = '0.1.8'
+VERSION = '0.1.9'
 
 # The full list of classifiers is available at
 # https://pypi.python.org/pypi?%3Aaction=list_classifiers