VNET extension #176
Merged
VNET extension #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later .
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
|
@rohit-joy @QingqingYuan Please review . |
rohit-joy
reviewed
May 10, 2018
There was a problem hiding this comment.
@rahulgouthamDOTgs, looks like the CI caught some pylint issues that weren't caught in the other repo. Please open bash using git\bin\bash.exe. Then run ./scripts/ci/test_static.sh to validate locally, as per the instructions in the General Guidelines above in summary.
fixing indentation
fixing more flake8 reported issues
rohit-joy
reviewed
May 11, 2018
| g.command('delete', 'delete', confirmation=True) | ||
| g.command('show', 'get') | ||
| g.command('list', 'list_by_server') | ||
| # g.generic_update_command('update') |
There was a problem hiding this comment.
Remove the commented lines.
rohit-joy
reviewed
May 11, 2018
| g.command('delete', 'delete', confirmation=True) | ||
| g.command('show', 'get') | ||
| g.command('list', 'list_by_server') | ||
| # g.generic_update_command('update') |
There was a problem hiding this comment.
Remove the commented lines.
williexu
suggested changes
May 11, 2018
| from codecs import open | ||
| from setuptools import setup, find_packages | ||
|
|
||
| VERSION = "10.0.0" |
There was a problem hiding this comment.
Why are you starting with such a high version?
There was a problem hiding this comment.
It's a remnant from private extension. Is it a blocker?
There was a problem hiding this comment.
Most extensions would start with something like 1.0.0 or 0.1.0 for preview.
It's strange starting off with 10.0.0 when there weren't any lower versions.
Would recommend changing but I'll leave the decision to you guys.
src/rdbms_vnet/setup.py
Outdated
| setup( | ||
| name='rdbms-vnet', | ||
| version=VERSION, | ||
| description='An Azure CLI Extension to manage VNET ACL rules for Azure MySQL and Azure PostgreSQL resources', |
There was a problem hiding this comment.
Please change the description to follow our summary_guidelines
ex. don't mention the CLI/extension/command-line
Fixing Review comments and formatting issues.
Fixing some more issues with source static and bug fixes
|
@rohit-joy @williexu @derekbekoe test_static.sh points to ./src/rdbms/azext_rdbms/ for pylint , do we need to make it generic ? |
|
@rahulgouthamDOTgs I recently made the change: https://github.com/Azure/azure-cli-extensions/blob/master/scripts/ci/test_static.sh#L12 |
Renaming _client_factory to _client_vnet_factory
|
@rohit-joy @williexu it looks like pylint is referring to rdbms/azext_rdbms/_client_factory.py and hence it complains , i tried changing the name to _client_vnet_factory.py , but its still looking at rdbms/azext_rdbms/ folder , how do i fix this ? :( |
|
@rahulgouthamDOTgs, could you try renaming the rdbms_vnet/azext_rdbms folder to rdbms_vnet/azext_rdbms_vnet? May have to change some references with this change. |
Reverting the last change
Renaming to azext_rdbms_vnet
More formatting issue fix
|
@rahulgouthamDOTgs, looks like the static analysis issues are resolved. |
adding code owners
Adding my email id :)
rohit-joy
approved these changes
May 11, 2018
williexu
approved these changes
May 11, 2018
wheel file is already uploaded to prodrdbmsclipackages
|
@rahulgouthamDOTgs, is it OK to merge? |
|
@rohit-joy yes , we are good to merge :) |
|
@rahulgouthamDOTgs, please fix CI issue in the index.json file. |
belmaiastar
added a commit
to belmaiastar/azure-cli-extensions
that referenced
this pull request
Jul 20, 2018
* Remove rdbms public CLI extension. (Azure#179) * Worm feature and listing usage by region (Azure#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (Azure#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (Azure#185) * iotext v0.4.5 (Azure#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (Azure#186) * VNET extension (Azure#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (Azure#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (Azure#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (Azure#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (Azure#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (Azure#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (Azure#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (Azure#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (Azure#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (Azure#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (Azure#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (Azure#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (Azure#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (Azure#212) * Updating az use call to azds cli (Azure#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (Azure#214) * Updating output messages to be printed in default mode (Azure#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (Azure#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (Azure#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (Azure#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (Azure#220) * index storage * index edits * added examples and new features (Azure#221) * updated api-version of arm to cli (Azure#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (Azure#225) * changes to dependency check (Azure#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (Azure#227)
belmaiastar
pushed a commit
to belmaiastar/azure-cli-extensions
that referenced
this pull request
Jul 20, 2018
* Remove rdbms public CLI extension. (Azure#179) * Worm feature and listing usage by region (Azure#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (Azure#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (Azure#185) * iotext v0.4.5 (Azure#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (Azure#186) * VNET extension (Azure#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (Azure#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (Azure#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (Azure#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (Azure#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (Azure#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (Azure#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (Azure#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (Azure#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (Azure#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (Azure#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (Azure#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (Azure#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (Azure#212) * Updating az use call to azds cli (Azure#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (Azure#214) * Updating output messages to be printed in default mode (Azure#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (Azure#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (Azure#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (Azure#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (Azure#220) * index storage * index edits * added examples and new features (Azure#221) * updated api-version of arm to cli (Azure#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (Azure#225) * changes to dependency check (Azure#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (Azure#227) * improved the deployment create command to now display back the public IP Addresses of the applications if available otherwise the status of the applications within the tempalte * added warning for when a network for an application can not be reached * added in displaying arm deployment errors * removed ~ folder * fixed the imports from client factory * removing files * specified errors and reduced clutter and depth of if statements * removed .vs * put in ascii friendly character * docs (Azure#228) * added better logic handling for errors and show running now * fixed import for http error from network client * changed setup.py to 0.9.0 and changed the deploying to not redisplay * removed the untested parts * fixed white space comma issue * updated version * added history.rst version * improved wording of history.rst * added more safety checks for getting network references. reduced duplicate checks for looping over applications. fixed outputting for a few different places * Automationstatic (Azure#232) * use flake8 config to apply exclusions, remove travis wait * pin pylint 1.9.2 for CI * fix link for extension summary for PRs (Azure#233) * Checks for license presence while disregarding '#\n' (Azure#237) * license ignore newlines * added licenses * cleanup * add static check as precheck (Azure#238) * add static check as precheck * made basic index verification part of precheck * added network ref parse ability for other common format * started adding validation precheck to deploying * now has validation error check first * changed len check of string * cleaned up output * fixed formatting * fixed formatting of EOF lines * removed logging statement * removed the no wait from validation because it didnt seem necessary * ref doc gen broken due to deprecation work (Azure#240) * should now just return expressions from the function and removed unused import * removed .idea files * should fix the inconsistent return formatting issue * added back missing new line * check_call will block child_process if enough output is sent to PIPE (Azure#243) * check_call will block child_process if enough output is sent to PIPE * run is unavailable in python2, opting for check_output which reads from the PIPE * remove PIPE * fixed client naming
williexu
pushed a commit
that referenced
this pull request
Jul 21, 2018
* Service Fabric Mesh - Public Preview (#22) * Mesh public preview (#26) * Private Preview 4 * Fix CI check * Use future print * Merge from master (#27) * Remove rdbms public CLI extension. (#179) * Worm feature and listing usage by region (#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (#185) * iotext v0.4.5 (#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (#186) * VNET extension (#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (#212) * Updating az use call to azds cli (#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (#214) * Updating output messages to be printed in default mode (#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (#220) * index storage * index edits * added examples and new features (#221) * updated api-version of arm to cli (#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (#225) * changes to dependency check (#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (#227) * [0.8.0] Update SDK to Mesh namespace * Use new namespace * Run tests * iteration1 comments * new lines * Drop commands for legacy resources * Add license header * Comments * Delete sbz * Api version * fix history * Mesh preview rc (#29) * Remove rdbms public CLI extension. (#179) * Worm feature and listing usage by region (#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (#185) * iotext v0.4.5 (#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (#186) * VNET extension (#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (#212) * Updating az use call to azds cli (#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (#214) * Updating output messages to be printed in default mode (#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (#220) * index storage * index edits * added examples and new features (#221) * updated api-version of arm to cli (#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (#225) * changes to dependency check (#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (#227) * improved the deployment create command to now display back the public IP Addresses of the applications if available otherwise the status of the applications within the tempalte * added warning for when a network for an application can not be reached * added in displaying arm deployment errors * removed ~ folder * fixed the imports from client factory * removing files * specified errors and reduced clutter and depth of if statements * removed .vs * put in ascii friendly character * docs (#228) * added better logic handling for errors and show running now * fixed import for http error from network client * changed setup.py to 0.9.0 and changed the deploying to not redisplay * removed the untested parts * fixed white space comma issue * updated version * added history.rst version * improved wording of history.rst * added more safety checks for getting network references. reduced duplicate checks for looping over applications. fixed outputting for a few different places * Automationstatic (#232) * use flake8 config to apply exclusions, remove travis wait * pin pylint 1.9.2 for CI * fix link for extension summary for PRs (#233) * Checks for license presence while disregarding '#\n' (#237) * license ignore newlines * added licenses * cleanup * add static check as precheck (#238) * add static check as precheck * made basic index verification part of precheck * added network ref parse ability for other common format * started adding validation precheck to deploying * now has validation error check first * changed len check of string * cleaned up output * fixed formatting * fixed formatting of EOF lines * removed logging statement * removed the no wait from validation because it didnt seem necessary * ref doc gen broken due to deprecation work (#240) * should now just return expressions from the function and removed unused import * removed .idea files * should fix the inconsistent return formatting issue * added back missing new line * check_call will block child_process if enough output is sent to PIPE (#243) * check_call will block child_process if enough output is sent to PIPE * run is unavailable in python2, opting for check_output which reads from the PIPE * remove PIPE * fixed client naming * Add to index.json * Update module name * Update author name * Fix CI error * Fix CI
kairu-ms
pushed a commit
that referenced
this pull request
May 20, 2024
* Merge Temp mavenir wheel into MAIN (#135) * added empty template parser * Initial scaffolding of some new classes * added utils, added base builder + reader + their children, added nfd and vhd processors * moved utils to common folder + added local file builder * Add some basic implementations * add new commands and restructure command groups * better naming for command groups * revert addition on the onboard command group * update HISTORY.rst * fix style issue * fix linting issues * added empty vhd and nfd processors; moved client factory from old repo * Add template parser interface (BaseParser) * Add parameters to BaseParser * Make defaults_path optional in base_parser * defaults_path defaults to None in base_parser * add helm chart parser class and common exceptions * add missing doc strings * Change parser class to input template class * added all input config params + comments; added common arm template config; added instructions for completing publish/delete * add typing to base processor and add copyright statement to new files * fixed formatting on input configs * fixed nsd input config + tidied other input config files * added comments for images; general formatting * rename template parsers to input templates and add helm chart processor * add __init__.py to folders * fixed imports + added innit in folders * fixed imports + added defaults for input params * Not quite complete first pass at definition folder handlers * added generate config log; fixed input config objects * rename InputTemplate to InputArtifacts * tidied write config + added read config; deleted json file checked in by mistake * added overwrite validation to generate config; added j2 templates to common * added validation to base config and nsd * Add UTs and fix up definition folder code * added validation to nsd + cnf; added default_file_name property; added tests for generate config; added example nsd-input.jsonc for testing * add vhd processor * remove leftover file from merge * added vnf config validation; improved comment spacing on input.json; fixed depends on format; changes type for optional params * added optional output file name param to generate config; removed misc print statements * Fix up some type hinting * added write manifest bicep and nf application to base handler; fixed helm config to produce correct bicep * push latest changes * Initial ArmInputTemplate class * Outline ArmBuildProcessor hierarchy * Update VNF tests to keep built output for comparison * WIP, for sharing with Jacob * Incremental update * added vnf config validation; improved comment spacing on input.json; fixed depends on format; changes type for optional params * added optional output file name param to generate config; removed misc print statements * Approximately complete ARM processor. No tests, no testing yet. * Fix artifact store reference * WIP * fixed cnf bicep template * fixed multiple helm/vhd/arm error; working vnfartifactmanifet; attempted vnfdefintiion with testing code still in; updated write bicep functions to take 2 arguments for vnf case * fixed cnfdef bicep; return correct type in cnf handler * Added outputfolder name to base handler; reorganised templates folder structure; added constants for cnf j2 templates; implemented build (tested with mocks) for cnf handler; implemented localfileACR artifact to_dict function; updated write for artifact_builder.py; added overwriting folder logic to defintion folder builder * renamed write manifest; updated nf templates to deploy initial resources; vnf templates working; vnf build commands working * added logic to cnf handler for manifest and definition supporting files + config mappings * fixed cnf params files; added render params for vnf * fix HelmChartInput issues * Merge arm-processor code into Jacob's branch (#127) * Initial ArmInputTemplate class * Outline ArmBuildProcessor hierarchy * Update VNF tests to keep built output for comparison * Initial ArmInputTemplate class * Outline ArmBuildProcessor hierarchy * Update VNF tests to keep built output for comparison * WIP, for sharing with Jacob * Incremental update * Approximately complete ARM processor. No tests, no testing yet. * Fix artifact store reference --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> * added build deploy params schema to base handler; added functionality for deployParams to be added as supporting file for cnd * fix majority of linting issues * renamed write on base handler to render; added build logic for manifest and artifact list for vnf * added write manifest bicep and nf application to base handler; fixed helm config to produce correct bicep * fixed cnf bicep template * Initial ArmInputTemplate class * complete helm chart processor * almost finished NFD processor * WIP, for sharing with Jacob * Incremental update * added vnf config validation; improved comment spacing on input.json; fixed depends on format; changes type for optional params * added optional output file name param to generate config; removed misc print statements * Approximately complete ARM processor. No tests, no testing yet. * WIP * fixed multiple helm/vhd/arm error; working vnfartifactmanifet; attempted vnfdefintiion with testing code still in; updated write bicep functions to take 2 arguments for vnf case * fixed cnfdef bicep; return correct type in cnf handler * Added outputfolder name to base handler; reorganised templates folder structure; added constants for cnf j2 templates; implemented build (tested with mocks) for cnf handler; implemented localfileACR artifact to_dict function; updated write for artifact_builder.py; added overwriting folder logic to defintion folder builder * renamed write manifest; updated nf templates to deploy initial resources; vnf templates working; vnf build commands working * added logic to cnf handler for manifest and definition supporting files + config mappings * fixed cnf params files; added render params for vnf * added build deploy params schema to base handler; added functionality for deployParams to be added as supporting file for cnd * renamed write on base handler to render; added build logic for manifest and artifact list for vnf * fix up code * fix base input * run isort * implemented vnf build + removed test code; fixed arm processor * fixed templates * removed multiple vhds from vnf + fixed bicep; made path to mappings optional for cnf * renamed write file to render contents * fixed helm chart processor + small tidy up * commit for build handover; not working + handover notes sent separately * run isort * fix issues in input classes * add generic schema and value mapping generation and fix arm and vhd processors * push changes I forgot to push before xmas * checked out fixed build processors and inputs from jdarby/add-build-processors * fix values and schema generation * add RET generation for ARM templates * fix linting issues * made input file name constant + renamed inputs to match changes * checked out build processor changes * Moved _render_deployment_params_schema and _build_deploy_params_schema to nfd base handler; added default_config logic to cnf handler;created deploymentParamers for cnf + vnf * changed j2 template for vhd image name * HELM CHART PROCESSOR CHANGES! fixed registry value path and depends on profile in cnf template * fixed nsd artifact manifest, changed artifact type in all processers (PROCESSOR CHANGE) * implemented nsd build get artifact manifest and get artifact list * added base bicep to all handlers; edited j2 templates to note that base resources should be deployed first on publish; made all build use constants * added to_dict for localfileACRartifact * added source namespcae and source reigstry to artifact + in helm processor callinh remote arc artifacts * finish nfd processor * add copyright statement to helm processor file * linting * created common params folder (making new jsonbuilder), adding get params config to base', renamed get_config to get_input_config; aded logging to vnf; chnged custom.py publish inputs * partially ready commit; added cmd context to base + added some logic to nsds * added all parameters constant * tidied vnf handler; added common params logic to cnf * markups inc tidy up * renamed snake_case param * add nsd output config * taken some input and build processor changes from jdarby/build_processor branch * Add logging, improve doc string and fix mypy errors for inputs * fix 2 bugs introduced by merging buildprocessors and adding json deploy params * fixed how aosm client is passed to build; properly get nfdv object with api client * refactored vnf handler to create processors upfront * refactor cnf to instantiate processors upfront * Improve docstrings, add logging and fix linting issues for build processors * nsd temp commit * fix missed conflict * fix linting and formatting issue * rename + add constants + add new definition tempalte * simplified render bicep definiton contents + removes all constants for filenames from nf handlers and templates * build nsd bicep core working * fixed nsd bicep * Fix two minor CLI bugs (#129) * Fix bug where the build directory wasn't deleted * Fix bug where the json wasn't output correctly * fixed incorrect merge fix --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * small fixes; removed location from nfd input, removed comma from vnd def template, fixed artifact version in nsds, fixed vhd validation * made cgs name constant to fix error in mappings * added store type to all the templates * tidy up + small markups * removed version state from the definition biceps * fixed bug where schemas and defaults were copied incorrectly * made artifact paths absolute in all cases except nsd nfs, where paht is relative to nsd output folder * added missing comments; renamed common params + edited its format; changed custom to take path * added existing back to all templates + descriptors of resources * Merge publish into temp wheel branch (#131) * Move artifact create from dict logic to instantiating code * Create CommandContext class to hold Azure clients and CLI options, and pass instance through to the delete and publish commands. * Mostly implemented and working publish. Lots of debug code still present. * Publish done and mostly tested. * Add some more logging. Remove help text referring to --order-params. * Update src/aosm/azext_aosm/common/artifact.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * fix merge conflicts --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Minor input improvements (#132) * fixed common params files for all * remove prints; remove sourcelocaldockerimage + add correct validation; edit input.json comments * fixed extract tar error * only create oras_client once - temp solution --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> * edited input file (#133) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * fixed getparamsconfig for vnf/nsd; added fixes for building correct python wheel * Achurchard/publish (#130) Markups from publish PR --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: jordlay <72226943+jordlay@users.noreply.github.com> * bug fixes for chart with subcharts * added ruamel * Use safe yaml loading * Move code out of import list * Fix errant config line bug * fixed deployparams error (#134) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * fixed yaml load error * disabled multi anchor yaml warning for values.yaml * delete accidental deployparams file --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Chaos Chhapi <chaos.chhapi@metaswitch.com> Co-authored-by: Jacob <53872686+jddarby@users.noreply.github.com> Co-authored-by: Jacob Darby <jdarby@microsoft.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: patrykkulik-microsoft <116072282+patrykkulik-microsoft@users.noreply.github.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * fix silly yaml import * moved config validate to init, commented out delete command, add context to publish + passed paths properly in custom.py * Add Helm template validation to the build method in the CLI (#136) * added empty template parser * Initial scaffolding of some new classes * added utils, added base builder + reader + their children, added nfd and vhd processors * moved utils to common folder + added local file builder * Add some basic implementations * add new commands and restructure command groups * better naming for command groups * revert addition on the onboard command group * update HISTORY.rst * fix style issue * fix linting issues * added empty vhd and nfd processors; moved client factory from old repo * Add template parser interface (BaseParser) * Add parameters to BaseParser * Make defaults_path optional in base_parser * defaults_path defaults to None in base_parser * add helm chart parser class and common exceptions * add missing doc strings * Change parser class to input template class * added all input config params + comments; added common arm template config; added instructions for completing publish/delete * add typing to base processor and add copyright statement to new files * fixed formatting on input configs * fixed nsd input config + tidied other input config files * added comments for images; general formatting * rename template parsers to input templates and add helm chart processor * add __init__.py to folders * fixed imports + added innit in folders * fixed imports + added defaults for input params * Not quite complete first pass at definition folder handlers * added generate config log; fixed input config objects * rename InputTemplate to InputArtifacts * tidied write config + added read config; deleted json file checked in by mistake * added overwrite validation to generate config; added j2 templates to common * added validation to base config and nsd * Add UTs and fix up definition folder code * added validation to nsd + cnf; added default_file_name property; added tests for generate config; added example nsd-input.jsonc for testing * add vhd processor * remove leftover file from merge * added vnf config validation; improved comment spacing on input.json; fixed depends on format; changes type for optional params * added optional output file name param to generate config; removed misc print statements * Fix up some type hinting * added write manifest bicep and nf application to base handler; fixed helm config to produce correct bicep * push latest changes * Initial ArmInputTemplate class * Outline ArmBuildProcessor hierarchy * Update VNF tests to keep built output for comparison * WIP, for sharing with Jacob * Incremental update * added vnf config validation; improved comment spacing on input.json; fixed depends on format; changes type for optional params * added optional output file name param to generate config; removed misc print statements * Approximately complete ARM processor. No tests, no testing yet. * Fix artifact store reference * WIP * fixed cnf bicep template * fixed multiple helm/vhd/arm error; working vnfartifactmanifet; attempted vnfdefintiion with testing code still in; updated write bicep functions to take 2 arguments for vnf case * fixed cnfdef bicep; return correct type in cnf handler * Added outputfolder name to base handler; reorganised templates folder structure; added constants for cnf j2 templates; implemented build (tested with mocks) for cnf handler; implemented localfileACR artifact to_dict function; updated write for artifact_builder.py; added overwriting folder logic to defintion folder builder * renamed write manifest; updated nf templates to deploy initial resources; vnf templates working; vnf build commands working * added logic to cnf handler for manifest and definition supporting files + config mappings * fixed cnf params files; added render params for vnf * fix HelmChartInput issues * Merge arm-processor code into Jacob's branch (#127) * Initial ArmInputTemplate class * Outline ArmBuildProcessor hierarchy * Update VNF tests to keep built output for comparison * Initial ArmInputTemplate class * Outline ArmBuildProcessor hierarchy * Update VNF tests to keep built output for comparison * WIP, for sharing with Jacob * Incremental update * Approximately complete ARM processor. No tests, no testing yet. * Fix artifact store reference --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> * added build deploy params schema to base handler; added functionality for deployParams to be added as supporting file for cnd * fix majority of linting issues * renamed write on base handler to render; added build logic for manifest and artifact list for vnf * added write manifest bicep and nf application to base handler; fixed helm config to produce correct bicep * fixed cnf bicep template * Initial ArmInputTemplate class * complete helm chart processor * almost finished NFD processor * WIP, for sharing with Jacob * Incremental update * added vnf config validation; improved comment spacing on input.json; fixed depends on format; changes type for optional params * added optional output file name param to generate config; removed misc print statements * Approximately complete ARM processor. No tests, no testing yet. * WIP * fixed multiple helm/vhd/arm error; working vnfartifactmanifet; attempted vnfdefintiion with testing code still in; updated write bicep functions to take 2 arguments for vnf case * fixed cnfdef bicep; return correct type in cnf handler * Added outputfolder name to base handler; reorganised templates folder structure; added constants for cnf j2 templates; implemented build (tested with mocks) for cnf handler; implemented localfileACR artifact to_dict function; updated write for artifact_builder.py; added overwriting folder logic to defintion folder builder * renamed write manifest; updated nf templates to deploy initial resources; vnf templates working; vnf build commands working * added logic to cnf handler for manifest and definition supporting files + config mappings * fixed cnf params files; added render params for vnf * added build deploy params schema to base handler; added functionality for deployParams to be added as supporting file for cnd * renamed write on base handler to render; added build logic for manifest and artifact list for vnf * fix up code * fix base input * run isort * implemented vnf build + removed test code; fixed arm processor * fixed templates * removed multiple vhds from vnf + fixed bicep; made path to mappings optional for cnf * renamed write file to render contents * fixed helm chart processor + small tidy up * commit for build handover; not working + handover notes sent separately * run isort * fix issues in input classes * add generic schema and value mapping generation and fix arm and vhd processors * push changes I forgot to push before xmas * checked out fixed build processors and inputs from jdarby/add-build-processors * fix values and schema generation * add RET generation for ARM templates * fix linting issues * made input file name constant + renamed inputs to match changes * checked out build processor changes * Moved _render_deployment_params_schema and _build_deploy_params_schema to nfd base handler; added default_config logic to cnf handler;created deploymentParamers for cnf + vnf * changed j2 template for vhd image name * HELM CHART PROCESSOR CHANGES! fixed registry value path and depends on profile in cnf template * fixed nsd artifact manifest, changed artifact type in all processers (PROCESSOR CHANGE) * implemented nsd build get artifact manifest and get artifact list * added base bicep to all handlers; edited j2 templates to note that base resources should be deployed first on publish; made all build use constants * added to_dict for localfileACRartifact * added source namespcae and source reigstry to artifact + in helm processor callinh remote arc artifacts * finish nfd processor * add copyright statement to helm processor file * linting * created common params folder (making new jsonbuilder), adding get params config to base', renamed get_config to get_input_config; aded logging to vnf; chnged custom.py publish inputs * partially ready commit; added cmd context to base + added some logic to nsds * added all parameters constant * tidied vnf handler; added common params logic to cnf * markups inc tidy up * renamed snake_case param * add nsd output config * taken some input and build processor changes from jdarby/build_processor branch * Add logging, improve doc string and fix mypy errors for inputs * fix 2 bugs introduced by merging buildprocessors and adding json deploy params * fixed how aosm client is passed to build; properly get nfdv object with api client * refactored vnf handler to create processors upfront * refactor cnf to instantiate processors upfront * Improve docstrings, add logging and fix linting issues for build processors * nsd temp commit * fix missed conflict * fix linting and formatting issue * rename + add constants + add new definition tempalte * simplified render bicep definiton contents + removes all constants for filenames from nf handlers and templates * build nsd bicep core working * fixed nsd bicep * Fix two minor CLI bugs (#129) * Fix bug where the build directory wasn't deleted * Fix bug where the json wasn't output correctly * fixed incorrect merge fix --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * small fixes; removed location from nfd input, removed comma from vnd def template, fixed artifact version in nsds, fixed vhd validation * made cgs name constant to fix error in mappings * added store type to all the templates * tidy up + small markups * removed version state from the definition biceps * fixed bug where schemas and defaults were copied incorrectly * made artifact paths absolute in all cases except nsd nfs, where paht is relative to nsd output folder * added missing comments; renamed common params + edited its format; changed custom to take path * added existing back to all templates + descriptors of resources * First stab at doing helm template - check the changes here * Merge publish into temp wheel branch (#131) * Move artifact create from dict logic to instantiating code * Create CommandContext class to hold Azure clients and CLI options, and pass instance through to the delete and publish commands. * Mostly implemented and working publish. Lots of debug code still present. * Publish done and mostly tested. * Add some more logging. Remove help text referring to --order-params. * Update src/aosm/azext_aosm/common/artifact.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * fix merge conflicts --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Minor input improvements (#132) * fixed common params files for all * remove prints; remove sourcelocaldockerimage + add correct validation; edit input.json comments * fixed extract tar error * only create oras_client once - temp solution --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> * edited input file (#133) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Add skip step * fixed getparamsconfig for vnf/nsd; added fixes for building correct python wheel * Achurchard/publish (#130) Markups from publish PR --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: jordlay <72226943+jordlay@users.noreply.github.com> * bug fixes for chart with subcharts * added ruamel * Use safe yaml loading * Move code out of import list * Fix errant config line bug * fixed deployparams error (#134) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * fixed yaml load error * Change "path_to_mappings" to "default_values" * Add unit tests * remove the merge mistake * Delete a file --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Chaos Chhapi <chaos.chhapi@metaswitch.com> Co-authored-by: Jacob <53872686+jddarby@users.noreply.github.com> Co-authored-by: Jacob Darby <jdarby@microsoft.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: jordlay <72226943+jordlay@users.noreply.github.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Pk5/add image parsing (#137) * Add image parsing * Add unit tests * Fix small log issue * Minor markup edits * Improve unit tests * remove the test_utils file * update HISTORY.rst * update HISTORY file * Validate that helm chart values exist (#138) * add validation of the default values for helm charts * Add unit tests * update HISTORY.rst * Markups * Jl/nsd publish paths (#139) * fix for relative path issue for nsd publish; fix for deployment parameters schema being wrong * Add image parsing * LocalFileACRArtifact converts bicep to ARM before upload. * Remove TODO comment that is done. Refactor convert to bicep code. * Add unit tests * Fix small log issue * Minor markup edits * Add location to configObject passed to NF template. Value is hardcoded to that provided in the input.jsonc file. * Add note on using NF name instead of NSD name when creating NFDInput * Minor fixes: - check attribute exists before accessing it\n - better logging\n - reduce nesting * input file (jsonc) comment updates. * Fix NSD generate --output-file handling bug * Minor markups. --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Patryk Kulik <patrykkulik@microsoft.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> * Bump version to 1.0.0b5 * Linting and typing (#141) Linting and type hinting fixes. * Temp 16feb wheel (#145) * added nexus arm processor; added nfvi type to vnfinput.json; added condition for calling each arm processor * pipe through nfvi type from vnf input to template; added nexus input; fixed mistakes in armprocessor * initial commit for children vnf handlers * added core and nexus config logic * fixed nexus input and nexus processor; fixed templates * generalised render manifest and render definition bicep functions to use one * added incorrect config error handling * added nexus flag to publish; added error handling for incorrect vnf type (if forgot to put nexus flag case); tidied nexus inputs * added vnf nexus base bicep; fixed vnf definition template; temp fix for image versions * moved render bicep to common/utils; replaced build base bicep with render bicep * general tidyup: removed prints, added return types * added nfvi type to nsds * removed old todos * refactored nexus handler, moved generate params code into processor * moved logic to base vnf handler; moved more logic to processor * fix template name in vnf j2 * fixed nexus image file * added nfvitype to nsd nf template by making new j2 + changing how nfd processor works * added nfvitype to nsd nf template by making new j2 + changing how nfd processor works * minor formatting * made vnfnexus a definition type; slight refactor of custom.py * removed nexus param, removed prints, added commented out test file * fixed flake8 + pylint issues * Base handler treats command inputs separately (#143) * refactored base handler init to treat inputs from different commands separately; added better validation * fixed error handling in base handler * fixed error typing --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * mypy fixes * fixed customLocation id for vnf nexus * markups from review inc moving build manifest to parent vnf handler * added better docstrings * updated history.rst * Achurchard/fix helm chart upload (#144) * Use helm push for Helm charts (not oras push) * Logging --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> * bumped version * Bug: No type in schema (#148) * first fix for anyOf logic error msg * Update src/aosm/azext_aosm/build_processors/base_processor.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Update src/aosm/azext_aosm/build_processors/base_processor.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Bug: Nexus Image Version Must be Semver (#149) * added semver checking to input config validation; moved split image path to utils * changed semver regex; renamed function * fixed typo * markups * fix typo --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Create RG if it doesn't exist (#150) * add validation resource group exists function * tidied up code * Update src/aosm/azext_aosm/definition_folder/reader/definition_folder.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * renaming from markups --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Bug Fix: NFD and NSD Manifest Names Clash (#147) * added sa_manifest and acr_manifest property, added sa and acr to manifest names; added nsd to nsd manifest name * create manifest name from nf/nsd name instead of acr/sa; fixed docs strings --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Fix Nexus Linting + Add Unit Tests (#146) * fixed pylint + flake8 errors * fix mypy errors * fixed artifact builder tests * temp commit for unit testing * temp push of broken tests * added new mocks (not perfect) for vnfs£ * fixed artifact write failure * More mypy fixes * fixed style issues --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> * Use ephemeral tempdir for generated helm package .tgz file. (#151) * Use ephemeral tempdir for generated helm package .tgz file. * Fix file_path bug if .tgz file was provided by user. --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * add to changelog; bump version * added check for filepath before making absolute (#154) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Template Parameters Bug (#156) * converted vhd parameters to camel case to match what aosm expects * markups + fixed apiVersion --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * fixed config comment (#153) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * removed image name parameter, added imageName to default config for arm and vhd input (#157) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * bumped version and updated changelog (#158) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Improve Unit Testing (#152) * moved working tests to new folder structure; added empty tests for processors and build * added empty generate cofnig tests; fixed and moved bicep,artifact and definitino folder builder tests * added nexus arm tests; removed outdated vnf mocks * added azure core tests for every function (including base) * fixed up core and nexus arm processor * fixed up arm processors; added logging to tests * added arm template tests * added test from copilot learning day * changed assert * removed build folder; added json dump to artifact and definition tests; improved arm processor testing * removed mock open and replaced with new templates * fixed linting --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Fix bool in schema bug (#160) * check object is a dict before looking for `type` key. --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Use common.utils function to check if docker/helm is installed (code deduplication). (#161) * changed configuration type from secret to open; updated changelog (#162) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Support using multiple images sources in our CLI (#142) * Initial stab at making the multiple registry support work * Update TODO * update TODO * merge fixes * add logic to find registry credentials * Code cleanup and adding unit tests * updates to the registry class * In Progress work * Working publish * Move _push_image_from_local_registry and copy_image into the registry class * tidy up changes * Namespace and style fixes * Minor input config change * unit tests * Do not push image namespace to target ACR * Make sure not to break the nexus part of the code * Update CHANGELOG * Fix error not being caught correctly * Minor comment change * Markups * Update warning * Change how we treat namespace and find images * markups * modify how we create the registry list --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> * Fix integration tests (#163) * Initial stab at making the multiple registry support work * Update TODO * update TODO * merge fixes * add logic to find registry credentials * Code cleanup and adding unit tests * updates to the registry class * In Progress work * Working publish * Move _push_image_from_local_registry and copy_image into the registry class * tidy up changes * Namespace and style fixes * Minor input config change * unit tests * Do not push image namespace to target ACR * Make sure not to break the nexus part of the code * Update CHANGELOG * initial commit for integration tests * Fix error not being caught correctly * Minor comment change * Fix integration tests * Moving files around * Working vnf integration test * Comment out test that is not working * Clean up the structure of the integration tests * Delete unnecessary tests * Fix CNF test and move a util function * fix other integration tests * Delete the broken tests folder * Fix the vnf test * move files around * Improve the update_input_file function * improve the nsd test * Move files around and improve the nsd output * remove unnecessary line * Update recording processors and recordings * Fix linting issues * bad merge change * Update the nsd output with Open CGVs * Fix few unit tests broken by merge * Markups --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Add docker dependency option to oras in setup.py (#164) Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> * Revert "Add docker dependency option to oras in setup.py (#164)" (#165) This reverts commit 9b6fcde. * update history + bump version (#166) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * hot fix: anyOf bug * hotfix: fixed 2 style errors * bumped version to 2 (#170) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Fix linting + tests for release (#171) * removed delete helptext and reran tests live * fixed linting --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * added license headers to fix release jobs (#172) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Add Webhook (#159) * initial attempt at adding roleOverride * add comma * removed comma as breaks single nf application * remove prints * fixed linting + updated history * fixed bug in nfd processor for vnfs; updated nsd tests * fixed lives tests * markups * markups2 --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Expose All PRs (#173) * Refactoring related to user customisable param exposure (#167) * Fix: Change 'deploymentParameters' to 'deployParameters' * Refactoring including: - Remove minor inconsistencies between related methods - Use named parameters in method calls to improve readability - Rename variables and methods to be more descriptive/accurate - Improve some exception messages - Make log messages clearer - Improve code comments - Improve type handling --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> * Allow all parameters to be exposed to operator (#169) * Fix: Change 'deploymentParameters' to 'deployParameters' * Refactoring including: - Remove minor inconsistencies between related methods - Use named parameters in method calls to improve readability - Rename variables and methods to be more descriptive/accurate - Improve some exception messages - Make log messages clearer - Improve code comments - Improve type handling * Comment out _find_image_pull_secrets_values_paths(). * Add expose_all function for NFDs. Includes extensive renaming of variables and methods, new code comments and docstrings. * Add expose_all_params to nfd-input.jsonc and plumb through. * Fix linting + tests for release (#171) * removed delete helptext and reran tests live * fixed linting --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * added license headers to fix release jobs (#172) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Markups * Add Webhook (#159) * initial attempt at adding roleOverride * add comma * removed comma as breaks single nf application * remove prints * fixed linting + updated history * fixed bug in nfd processor for vnfs; updated nsd tests * fixed lives tests * markups * markups2 --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * fixed line too long * markups including removing multiple instances * fixed all unit tests based on new param (expose_all), removed param (multiple_instances), refactoring of deploymentParameters to deployParams, and removal of using values.schema.json * ran live tests + removed dependsOn * added getting defaults from arm template + added special logic for when defaults are rg().location * fixed tests + fixed styling * ran live tests --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: jordlay <72226943+jordlay@users.noreply.github.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Patryk Kulik <patrykkulik@microsoft.com> --------- Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Patryk Kulik <patrykkulik@microsoft.com> * updated history * Fix minor config bugs (#174) * renamed nfdvName to nfdv * changed comment for name in NF RET for nsd input * added ArmTemplate optional comment to NSD input config * changed nfdv examples in mock cgvs * added 1:1 mapping between nfdvs and nfvisFromSite * removed nfvi_type from nsd input config * markups * fixed tests + styling; markups --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Help text additions (#175) * Add long summary, parameters and examples to help text. * Remove parameters from help file. Instead, use the help defined in _params.py. Minor updates to text of latter. * Fix lines too long (#176) * updated changelog (#180) * updated changelog * markups --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Autogen CLI: (#181) - Add examples - Minor rewording - Ensure all commands are preview * Add quotes to the CNF input config image sources comment (#182) * Bump jinja2 to 3.1.4. (#190) * Remove azure-storage-blob from dependencies. (#192) * Pk5/fix integration tests for release (#195) * Add retry logic to fix integration tests * Modify the publisher name because previous name is used up * Regenerate the recordings * Re-record test (#196) * ran vnf test live (#197) Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Make the vnf test live only (#198) --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Chaos Chhapi <chaos.chhapi@metaswitch.com> Co-authored-by: Jacob <53872686+jddarby@users.noreply.github.com> Co-authored-by: Jacob Darby <jdarby@microsoft.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: patrykkulik-microsoft <116072282+patrykkulik-microsoft@users.noreply.github.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> Co-authored-by: Patryk Kulik <patrykkulik@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later .
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
./scripts/ci/test_static.shlocally? (pip install pylint flake8required)python scripts/ci/test_index.py -qlocally?For new extensions: