{storage-preview} Add hns soft delete #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
storage-preview |
3 tasks
3 tasks
Juliehzl
force-pushed
the
hns
branch
3 times, most recently
from
7581ccf to
385a3f5
Compare
evelyn-ys
reviewed
May 28, 2021
evelyn-ys
reviewed
May 28, 2021
evelyn-ys
reviewed
May 28, 2021
src/storage-preview/azext_storage_preview/operations/filesystem.py
Outdated
Show resolved
Hide resolved
evelyn-ys
reviewed
May 28, 2021
src/storage-preview/azext_storage_preview/operations/filesystem.py
Outdated
Show resolved
Hide resolved
evelyn-ys
reviewed
May 28, 2021
Comment on lines
+40
to
+42
| if pages.continuation_token: | ||
| next_marker = {"nextMarker": pages.continuation_token} | ||
| result.append(next_marker) |
There was a problem hiding this comment.
I noticed that in main repo, we add next_marker to result or warning message according to --show-next-marker. Why we don't need such parameter and just make adding to result as default behavior?
There was a problem hiding this comment.
as warning message is legacy method, to not break customer, we still keep it. Adding next marker in result will give customer better experience to get the marker value instead of parsing stderr.
Co-authored-by: Yishi Wang <yishiwang@microsoft.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.