[datafactory] Regenerate datafactory to support new linked service types #3239
Conversation
fengzhou-msft
force-pushed
the
regenerate_datafactory
branch
from
b331fd2 to
5a77375
Compare
|
@fengzhou-msft There're breaking changes between the previous generated code and now, such as |
…re-cli-extensions into regenerate_datafactory
| factory_vsts_configuration=None, | ||
| factory_git_hub_configuration=None, | ||
| global_parameters=None): | ||
| def datafactory_create(client, |
There was a problem hiding this comment.
wondering why do we need to overide this? looks the same as the generated code ?
There was a problem hiding this comment.
In generated code, identity is empty: factory['identity'] = {}. Portal behavior is enabling system assigned identity by default, the change aligns the behavior with Portal.
There was a problem hiding this comment.
Maybe can try to set default value for identity ?
There was a problem hiding this comment.
and hide this parameter with directive
There was a problem hiding this comment.
The parameter is already hidden. The default value is not a str, but an object, is it able to do so?
|
@changlong-liu Could you also take a look at this PR ? see if all these changes related with generated test or examples are expected ? Thanks |
|
Should be fine. The test breaking change comes from some early requirements like Azure/autorest.az#600 Looks much manual efforts were spent on fixing test breaking changes. We may need to be more cautious on the test interface changes later. |
| @@ -101,6 +109,9 @@ def get_action(self, values, option_string): # pylint: disable=no-self-use | |||
| v = properties[k] | |||
| if kl == 'name': | |||
| d['name'] = v[0] | |||
| else: | |||
| raise CLIError('Unsupported Key {} is provided for parameter folder. All possible keys are: name'. | |||
There was a problem hiding this comment.
Generated code in extensions still uses CLIError to be compatible with older version of CLI.
| @@ -10,7 +10,7 @@ | |||
| from setuptools import setup, find_packages | |||
|
|
|||
| # HISTORY.rst entry. | |||
| VERSION = '0.2.0' | |||
| VERSION = '0.1.0' | |||
There was a problem hiding this comment.
Caused by codegen change. The VERSION here will now be overwritten by from azext_datafactory.manual.version import VERSION and that is changed to 0.3.0 manually.
Resolve #3223
Resolve #2872
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.