Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Add ossku parameter for cluster and nodepool creation #3375

Merged
merged 4 commits into from
May 20, 2021

Conversation

hbeberman
Copy link
Contributor

This pull request adds support for the new ossku parameter to cluster and nodepool creation. This OSSKU is used to select the OS image (Ubuntu or CBLMariner) for container host VM.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@hbeberman hbeberman requested a review from andyliuliming as a code owner May 14, 2021 02:04
@hbeberman hbeberman force-pushed the azcli_add_ossku_parameter branch 2 times, most recently from 2def1c9 to 1f528de Compare May 17, 2021 18:51
Copy link
Contributor

@JunSun17 JunSun17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yonzhan
Copy link
Collaborator

yonzhan commented May 18, 2021

AKS

@yonzhan yonzhan requested review from Juliehzl and zhoxing-ms May 18, 2021 23:48
@yonzhan yonzhan added this to the S188 milestone May 18, 2021
@hbeberman hbeberman force-pushed the azcli_add_ossku_parameter branch from 1f528de to 2e26565 Compare May 20, 2021 16:48
@JunSun17 JunSun17 merged commit 56505e3 into Azure:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants