Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] fix aks pr check-in test pipeline #3389

Merged
merged 8 commits into from
May 26, 2021

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented May 17, 2021

Base on PR#3415, this PR further fix some other known issues of the AKS PR check-in test pipeline. The main changes are as follows:

  • Update az_aks_tool, add path check to avoid unexpected errors caused by invalid path
  • Fix the problem that the variable passed to az_aks_tool in the extensions test script is lost
  • Add two new test cases excluded by default (test_aks_disable_local_accounts, test_aks_update_to_msi_cluster_with_addons)
  • Add a new pipeline variable EXT_TEST_MATRIX to override the default filtering rules

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented May 17, 2021

AKS

@FumingZhang FumingZhang force-pushed the fuming/fix-pipeline branch from ac93c44 to 64ccde2 Compare May 19, 2021 11:01
@yonzhan yonzhan requested review from zhoxing-ms and Juliehzl May 20, 2021 03:59
@yonzhan yonzhan added this to the S188 milestone May 20, 2021
@@ -67,6 +67,9 @@ def main():
print("raw args: {}".format(sys.argv))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please help add comments to the real code changes?
a huge PR is a bit hard to do review.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, working on that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update key changes in PR description section.

Copy link
Member

@andyliuliming andyliuliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please separate the non-logicial change with the real code chagne.

@FumingZhang FumingZhang force-pushed the fuming/fix-pipeline branch 2 times, most recently from 39360ba to 2d72ca1 Compare May 25, 2021 09:03
@FumingZhang FumingZhang force-pushed the fuming/fix-pipeline branch from 2d72ca1 to 1b09a31 Compare May 25, 2021 09:09
@Juliehzl Juliehzl merged commit 9b14178 into Azure:master May 26, 2021
@FumingZhang FumingZhang deleted the fuming/fix-pipeline branch June 10, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants