[k8s-configuration] Update sourceControlConfiguration SDK Models to Track2 #3676
Conversation
[pull] release from Azure:master
…into k8s-configuration
…into k8s-extension/public-preview
…into k8s-configuration
…azure-cli-extensions into k8s-configuration
…into k8s-configuration
* Add check for provider registration and refactor * Fix bug in checking registration * Add license header to utils * Update private key check and error messaging * Update based on refactoring * Fix failing tests * Add provider registration check * Create a test for uppercase url, address comments * Add blank line to fix style check
…into k8s-configuration
* Update models to track2 * Increase k8s-configuration version number * Update kind version * Change error to warning because of DSA failure
jonathan-innis
force-pushed
the
k8s-configuration-release-1.1.0
branch
from
c26cd0f to
9722b66
Compare
|
k8s-configuration |
|
Could you run some live tests for these changes? |
What kind of live tests are you looking for? We have had issue with live tests previously because we require an AKS cluster and connected cluster to be pre-provisioned in order to run tests against it |
OK, I see. I also would like to ask can all the tests cover these changes, and have you rerun those tests in record mode? |
|
Record mode is difficult to run as well because some of these resources take identity which is not repeatable in record mode. We have an E2E test suite that we run on our end that covers all cases |
|
OK, it is suggested to fix those issues related tests in live mode/record mode in the future, so that our pipeline can better maintain and test the code quality |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.