Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[containerapp] Add Support for Qdrant dev service #6726

Merged
merged 10 commits into from
Sep 13, 2023
Merged

[containerapp] Add Support for Qdrant dev service #6726

merged 10 commits into from
Sep 13, 2023

Conversation

bgashirabake
Copy link
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 5, 2023 •
edited
Loading

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd containerapp service qdrant sub group containerapp service qdrant added

@azure-client-tools-bot-prd
Copy link

Hi @bgashirabake,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 5, 2023

containerapp

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 5, 2023
@microsoft-github-policy-service
Copy link
Contributor

Thank you for your contribution bgashirabake! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Sep 5, 2023
@bgashirabake
Copy link
Contributor Author

bgashirabake commented Sep 6, 2023 •
edited
Loading

this is ready for review, i believe. cc: @Greedygre @Juliehzl @zhoxing-ms

@bgashirabake
Copy link
Contributor Author

comment add.

@bgashirabake
Copy link
Contributor Author

more comment add.

@bgashirabake
Copy link
Contributor Author

added env deletion after test run.

@bgashirabake bgashirabake marked this pull request as draft September 12, 2023 16:39
@bgashirabake bgashirabake marked this pull request as ready for review September 12, 2023 17:38
@bgashirabake
Copy link
Contributor Author

@zhoxing-ms could you please help review this PR. it's a part of ongoing Springboard dev services work for container apps and some upcoming demos are contingent on it. thank you!!

@zhoxing-ms
Copy link
Contributor

@Greedygre Could you please help review this PR?

@zhoxing-ms
Copy link
Contributor

#6726 (comment) If you want to release a new extension version for this PR, please also upgrade the version defined in setup.py

@Greedygre
Copy link
Contributor

Greedygre commented Sep 13, 2023 •
edited
Loading

Hi @bgashirabake
Could you please fix comments for the history.rst?
Please rebase to main branch, and add history about your feature in upcoming. You can not update a released version's history section.

@Greedygre
Copy link
Contributor

@Greedygre Could you please help review this PR?

I have reviewed this PR.

@Greedygre
Copy link
Contributor

Greedygre commented Sep 13, 2023 •
edited
Loading

#6726 (comment) If you want to release a new extension version for this PR, please also upgrade the version defined in setup.py

BTW, @bgashirabake
We generally release new extension versions periodically. Please do not update setup.py.

@bgashirabake
Copy link
Contributor Author

@Greedygre Could you please help review this PR?

i hadn't seen @Greedygre's comments. resolving them now.

Greedygre
Greedygre approved these changes Sep 13, 2023
View reviewed changes
src/containerapp/HISTORY.rst Outdated Show resolved Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py Outdated Show resolved Hide resolved
src/containerapp/HISTORY.rst Outdated Show resolved Hide resolved
@zhoxing-ms zhoxing-ms merged commit 1bd1e94 into Azure:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Greedygre Greedygre Greedygre approved these changes

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@yonzhan yonzhan Awaiting requested review from yonzhan

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@yanzhudd yanzhudd Awaiting requested review from yanzhudd

@jsntcy jsntcy Awaiting requested review from jsntcy

@ruslany ruslany Awaiting requested review from ruslany

@sanchitmehta sanchitmehta Awaiting requested review from sanchitmehta

@ebencarek ebencarek Awaiting requested review from ebencarek

@JennyLawrance JennyLawrance Awaiting requested review from JennyLawrance

@howang-ms howang-ms Awaiting requested review from howang-ms

@vinisoto vinisoto Awaiting requested review from vinisoto

@chinadragon0515 chinadragon0515 Awaiting requested review from chinadragon0515

@vturecek vturecek Awaiting requested review from vturecek

@torosent torosent Awaiting requested review from torosent

@pagariyaalok pagariyaalok Awaiting requested review from pagariyaalok

@Juliehzl Juliehzl Awaiting requested review from Juliehzl

@jijohn14 jijohn14 Awaiting requested review from jijohn14

Assignees

@zhoxing-ms zhoxing-ms

Labels
Auto-Assign Auto assign by bot ContainerApp customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
September 2023 (2023-09-26)
Development

Successfully merging this pull request may close these issues.
4 participants
@bgashirabake @yonzhan @zhoxing-ms @Greedygre