Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new command az spring list-support-server-versions #6757

Merged
merged 8 commits into from
Sep 17, 2023
Merged

Add new command az spring list-support-server-versions #6757

merged 8 commits into from
Sep 17, 2023

Conversation

yilims
Copy link
Contributor

@yilims yilims commented Sep 14, 2023

Related command

Add new command az spring list-support-server-versions to list all supported server versions.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 14, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️spring
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd spring list-support-server-versions cmd spring list-support-server-versions added

@azure-client-tools-bot-prd
Copy link

Hi @yilims,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 14, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@yilims yilims changed the title Add new command az spring list-support-server-versions to list all… Add new command az spring list-support-server-versions Sep 14, 2023
@yilims
Copy link
Contributor Author

yilims commented Sep 15, 2023

@zhoxing-ms : could you pls help to review & merge the PR?

@zhoxing-ms
Copy link
Contributor

Please add some new tests for this PR

@yilims
Copy link
Contributor Author

yilims commented Sep 16, 2023

Please add some new tests for this PR

@zhoxing-ms : added test case, thanks!

@zhoxing-ms zhoxing-ms merged commit b59b272 into Azure:main Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants