[ContainerApp] az containerapp replica count: app/revision scope #6828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
requested review from
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl,
jijohn14 and
Greedygre
|
Can I get reviews on this PR? @Greedygre, @Juliehzl |
pagariyaalok
reviewed
Oct 5, 2023
pagariyaalok
reviewed
Oct 5, 2023
Greedygre
reviewed
Oct 6, 2023
Co-authored-by: xinyu pang <46143499+Greedygre@users.noreply.github.com>
Greedygre
approved these changes
Oct 6, 2023
|
Hi @zhoxing-ms |
yanzhudd
approved these changes
Oct 10, 2023
bgashirabake
pushed a commit
to bgashirabake/azure-cli-extensions
that referenced
this pull request
Oct 16, 2023
zhoxing-ms
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Just out of curiosity, I would like to confirm why the projects folder was added at that time? @Juancpani @Greedygre
There was a problem hiding this comment.
Hi @Juancpani
Is this projects folder added by mistake?
There was a problem hiding this comment.
Yes, the projects folder addition was a mistake. We should remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.