Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Email Crud Operations using Az Dev Tools #7169

Merged

Conversation

ddouglas-msft
Copy link
Contributor

Adds operations for the Azure Communication Services Email Service

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 10, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️communication
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd communication email create cmd communication email create added
⚠️ 1001 - CmdAdd communication email delete cmd communication email delete added
⚠️ 1011 - SubgroupAdd communication email domain sub group communication email domain added
⚠️ 1001 - CmdAdd communication email list cmd communication email list added
⚠️ 1001 - CmdAdd communication email show cmd communication email show added
⚠️ 1001 - CmdAdd communication email update cmd communication email update added
⚠️ 1001 - CmdAdd communication email wait cmd communication email wait added

Copy link

Hi @ddouglas-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 10, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@kairu-ms kairu-ms requested a review from AllyW January 12, 2024 01:55
@ddouglas-msft
Copy link
Contributor Author

Hello @AllyW. Any updates?

@jsntcy jsntcy requested a review from ReaNAiveD January 31, 2024 11:54
@AllyW
Copy link
Member

AllyW commented Feb 1, 2024

@ddouglas-msft please also make a pr in aaz repo (https://github.com/Azure/aaz) with the code changes in dev env

@@ -4,7 +4,7 @@
# --------------------------------------------------------------------------------------------


VERSION = '1.8.0b1'
VERSION = '1.8.1b1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our CLI Extension Version Transition Table, the version should be 1.8.0b2.
Please also update azext.isPreview to true in azext_metadata.json as well if you want to release as preview version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been updated per your other PR feedback

@ddouglas-msft
Copy link
Contributor Author

@ddouglas-msft please also make a pr in aaz repo (https://github.com/Azure/aaz) with the code changes in dev env

The updates are in this PR.

Azure/aaz#408

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 9, 2024

Please fix CI issues

@ddouglas-msft
Copy link
Contributor Author

Please fix CI issues

Thanks. I have fixed the issue with the indent.

@ddouglas-msft
Copy link
Contributor Author

Hello @yonzhan and @AllyW . Is there anything else missing?

@ddouglas-msft
Copy link
Contributor Author

Hello @AllyW, @yonzhan, @kairu-ms, @jsntcy. Any updates on this PR?

Co-authored-by: Yu Chen <16348853+jsntcy@users.noreply.github.com>
@necusjz necusjz merged commit a218f7f into Azure:main Feb 22, 2024
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ communication ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=132640&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants