-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container Apps Extension: Add Circuit Breaker Support for Dapr Component Resiliency #7228
Container Apps Extension: Add Circuit Breaker Support for Dapr Component Resiliency #7228
Conversation
Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Bernd Verst <github@bernd.dev>
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
containerapp env dapr-component resiliency create | cmd containerapp env dapr-component resiliency create added parameter in_circuit_breaker_consecutive_errors |
||
containerapp env dapr-component resiliency create | cmd containerapp env dapr-component resiliency create added parameter in_circuit_breaker_interval |
||
containerapp env dapr-component resiliency create | cmd containerapp env dapr-component resiliency create added parameter in_circuit_breaker_timeout |
||
containerapp env dapr-component resiliency create | cmd containerapp env dapr-component resiliency create added parameter out_circuit_breaker_consecutive_errors |
||
containerapp env dapr-component resiliency create | cmd containerapp env dapr-component resiliency create added parameter out_circuit_breaker_interval |
||
containerapp env dapr-component resiliency create | cmd containerapp env dapr-component resiliency create added parameter out_circuit_breaker_timeout |
||
containerapp env dapr-component resiliency update | cmd containerapp env dapr-component resiliency update added parameter in_circuit_breaker_consecutive_errors |
||
containerapp env dapr-component resiliency update | cmd containerapp env dapr-component resiliency update added parameter in_circuit_breaker_interval |
||
containerapp env dapr-component resiliency update | cmd containerapp env dapr-component resiliency update added parameter in_circuit_breaker_timeout |
||
containerapp env dapr-component resiliency update | cmd containerapp env dapr-component resiliency update added parameter out_circuit_breaker_consecutive_errors |
||
containerapp env dapr-component resiliency update | cmd containerapp env dapr-component resiliency update added parameter out_circuit_breaker_interval |
||
containerapp env dapr-component resiliency update | cmd containerapp env dapr-component resiliency update added parameter out_circuit_breaker_timeout |
Hi @berndverst, |
Hi @berndverst, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
Signed-off-by: Bernd Verst <github@bernd.dev>
257a71d
to
360c89c
Compare
Signed-off-by: Bernd Verst <github@bernd.dev>
src/containerapp/azext_containerapp/tests/latest/test_containerapp_dapr_resiliency.py
Outdated
Show resolved
Hide resolved
Hi @yash-nisar Please help to review and approve this PR about Dapr component. |
Signed-off-by: Bernd Verst <github@bernd.dev>
src/containerapp/azext_containerapp/daprcomponent_resiliency_decorator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Bernd Verst <github@bernd.dev>
@Greedygre the integration tests seem to fail with a service binding / springboard related issue. No idea what's happening there. The following passes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because the test failures seem to be unrelated.
Signed-off-by: Bernd Verst <github@bernd.dev>
FYI the unrelated failure is:
caused by:
|
Hi, I will fix this I issue in this PR: https://github.com/Azure/azure-cli-extensions/pull/7236/files |
src/containerapp/azext_containerapp/tests/latest/test_containerapp_dapr_resiliency.py
Outdated
Show resolved
Hide resolved
Please resolve the conflicts. |
…mponentresiliencycbs
Signed-off-by: Bernd Verst <github@bernd.dev>
@Greedygre feedback addressed. Thanks! |
Azure Container Apps: Adds support for Circuit Breakers in Dapr Component Resiliency (new properties available in API
2023-11-02-preview
)Related command
az containerapp env dapr-component resiliency create
andaz containerapp env dapr-component resiliency update
have been updated with new flags. See help command.General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
- [] My extension description/summary conforms to the Extension Summary Guidelines.About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.