Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Show ACS configs #7296

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

jiec-msft
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 19, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️spring
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd spring application-configuration-service config sub group spring application-configuration-service config added

Copy link

Hi @jiec-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 19, 2024

Spring

@jiec-msft jiec-msft force-pushed the mason/show-acs-configs branch 3 times, most recently from d1ccb6e to 48390c6 Compare February 21, 2024 14:28
@jiec-msft jiec-msft force-pushed the mason/show-acs-configs branch 2 times, most recently from 7b6b65e to 2f29341 Compare February 22, 2024 06:52
@jiec-msft
Copy link
Contributor Author

This is in draft state, need to add more unit tests

@jiec-msft jiec-msft force-pushed the mason/show-acs-configs branch 3 times, most recently from 11ed5ff to a0c136d Compare March 9, 2024 07:51
@yanzhudd
Copy link
Contributor

Please resolve code conflicts.

@yanzhudd
Copy link
Contributor

this PR seems to be a draft PR. If it is ready to review, please convert it to normal state.

@yanzhudd
Copy link
Contributor

please note that CLI is only responsible for code style and specification but not business logic, so it is better to involve service team to review it as well.

…ation Service from upstream Git repositories.
@jiec-msft jiec-msft force-pushed the mason/show-acs-configs branch from a0c136d to dd750b0 Compare March 21, 2024 03:52
@jiec-msft jiec-msft marked this pull request as ready for review March 21, 2024 03:54
@yanzhudd yanzhudd merged commit 428d2a9 into Azure:main Mar 21, 2024
14 of 15 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=141411&view=results

jiec-msft added a commit to jiec-msft/azure-cli-extensions that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants