Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove portal commands from apic-extension #7365

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

blackchoey
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az apic service portal *

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 8, 2024

❌Azure CLI Extensions Breaking Change Test
❌apic-extension
rule cmd_name rule_message suggest_message
1012 - SubgroupRemove apic service portal sub group apic service portal removed please confirm sub group apic service portal removed

Copy link

Hi @blackchoey,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 8, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@yonzhan yonzhan requested a review from jsntcy March 8, 2024 08:40
@blackchoey
Copy link
Contributor Author

@jsntcy this is my PR to contribute Azure CLI extension, please hold on PR merge until I get approval from my teammate.
I also have some questions regarding the auto generated code. It would be great if you could help answer some of them.
Thank you!

@jsntcy jsntcy requested review from AllyW, necusjz and ReaNAiveD March 8, 2024 08:55
Copy link

⚠️ Suggestions

Module: apic-extension

  • Update version to 1.0.0b5 in setup.py
  • Set azext.isPreview to true in azext_apic-extension/azext_metadata.json

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@AllyW AllyW merged commit d190373 into Azure:main Mar 18, 2024
14 of 15 checks passed
@blackchoey blackchoey deleted the feature/remove-portal-command branch April 2, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants