Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NetworkApiVersion for Vmss with OrchestraionMode == Flexible #17830

Closed
szimmer-dev opened this issue Apr 23, 2021 · 3 comments · Fixed by #18132
Closed

Support NetworkApiVersion for Vmss with OrchestraionMode == Flexible #17830

szimmer-dev opened this issue Apr 23, 2021 · 3 comments · Fixed by #18132
Assignees
Milestone

Comments

@szimmer-dev
Copy link

szimmer-dev commented Apr 23, 2021

Resource Provider
CRP

Description of Feature or Work Requested

If VMSS Orchestration mode is Flexible allow users to specify network-api-verision which will populate the networkApiVersion in the networkProfile of the VMSS

sample commands:

image

Background:
User Experience Doc

When a VMSS has orchestration mode set to Flexible, specifying the virtual machine profile is now possible, and will create VMs that are registered with ARM as top level VMs (rather than special VMScaleSetVMs).
When specifying the networkProfile for VMSS Flexible VMSSes we require that the networkApiVersion is populated, networkApiVersion cannot be populated if VMSS Orchestration mode is not flexible.

Additionally if a networkProfile for a VMSS is being added, and OrcehstrationMode == Flexbile, if the user does not provide a networkApiVersion automatically populate version = "2020-11-01"

Minimum API Version Required
2021-03-01

Swagger Link
Swagger pull request: Azure/azure-rest-api-specs#13449

We are concerned specifically with the vmscaleset.properties.virtualmachineprofile.properties.networkProfile.networkApVersion property being set.

Target Date
6/15/2021

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Apr 23, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Apr 23, 2021
@yungezz
Copy link
Member

yungezz commented Apr 23, 2021

2021-03-01 API version not available yet.

@szimmer-dev
Copy link
Author

I was told to make the design request now, so that we can get the design approved, and then when 2021-03-01 is published we will have an approved design.

Is this not the correct appoach?

@yungezz
Copy link
Member

yungezz commented Apr 23, 2021

you're right @szimmerMicrosoft. We need to track status of Swagger, then make sure there's enough time buffer for Python SDK and CLI to catch 5/25 target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants