Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network interface configuration schema for virtual machine network profile #13449

Merged
merged 15 commits into from
Apr 23, 2021
Merged

Add network interface configuration schema for virtual machine network profile #13449

merged 15 commits into from
Apr 23, 2021

Conversation

basharg
Copy link
Contributor

@basharg basharg commented Mar 16, 2021 •
edited by Sandido
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @basharg Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 16, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 11 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: primary
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9625
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: primary
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9699
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableAcceleratedNetworking
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9715
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableFpga
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9719
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableIPForwarding
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9723
    ⚠️ R4021 - DescriptionAndTitleMissing 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9606
    ⚠️ R4021 - DescriptionAndTitleMissing 'sku' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9610
    ⚠️ R4021 - DescriptionAndTitleMissing 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9675
    ⚠️ R4021 - DescriptionAndTitleMissing 'dscpConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9742
    ⚠️ R4021 - DescriptionAndTitleMissing 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9757


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L36
    ❌ D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Disks_Delete'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L223
    ❌ D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Disks_GrantAccess'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L327
    ❌ D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Disks_RevokeAccess'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L374
    ❌ D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Snapshots_Update'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L465
    ❌ D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Snapshots_Delete'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L544
    ❌ D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Snapshots_GrantAccess'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L648
    ❌ D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Snapshots_RevokeAccess'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L695
    ❌ R2020 - RequiredPropertiesMissingInResourceModel Model definition 'SubResourceWithColocationStatus' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L7131
    ❌ R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Compute/stable/2021-03-01/compute.json#L9965
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2021-03-01
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️❌Cross Version BreakingChange (Base on preview version): 11 Errors, 4 Warnings failed [Detail]

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1008 - ModifiedOperationId The operation id has been changed from 'VirtualMachines_GetExtensions' to 'VirtualMachineExtensions_List'. This will impact generated code.
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L1824:7
    Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L646:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'managed' renamed or removed?
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L7031:7
    Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L3160:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L8572:7
    Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L3687:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'overProvision' renamed or removed?
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L11659:7
    Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L5144:7
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'enum' value than the previous one.
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L8628:9
    Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L3723:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'enum' value than the previous one.
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L8997:9
    Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L3925:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'enum' value than the previous one.
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L9949:9
    Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L4400:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'enum' value than the previous one.
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L10338:9
    Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L4579:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'enum' value than the previous one.
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L10746:9
    Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L4834:9
    ❌ 1037 - ConstraintIsWeaker The new version has a less constraining 'enum' value than the previous one.
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L10647:9
    Old: Microsoft.Compute/preview/2016-04-30-preview/compute.json#L4782:9
    ️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️❌[Staging] SDK Track2 Validation: 1 Errors, 0 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ❌ PreCheck/DuplicateSchema "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-03-01",
    "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: undefined => "description":"The Offer Promotion Code.",
    "$ref":"#/components/schemas/schemas:1286" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."


    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-03-01",
    "details":"Error: Plugin prechecker reported failure."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 16, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from c26049db4009fde9b0b4449a5dd5ddfa5bf784cf. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-04-12 19:05:05 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-compute-generated"
cmderr	[generate.py] 2021-04-12 19:05:05 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-04-12 19:05:05 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.23 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated --java.namespace=com.azure.resourcemanager.compute.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
cmderr	[generate.py] 2021-04-12 19:06:27 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-04-12 19:06:27 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-04-12 19:06:27 INFO [POM][Skip] pom already has module azure-resourcemanager-compute-generated
cmderr	[generate.py] 2021-04-12 19:06:27 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-04-12 19:06:27 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-04-12 19:06:27 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Preview SDK Changes] 
      cmderr	[Inst] 2021-04-12 19:10:48 DEBUG Got artifact_id: azure-resourcemanager-compute-generated
cmderr	[Inst] 2021-04-12 19:10:48 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-04-12 19:10:48 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-04-12 19:10:48 DEBUG Match jar package: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-04-12 19:10:48 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13449/azure-sdk-for-java/azure-resourcemanager-compute-generated/azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-compute-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-compute-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from c26049db4009fde9b0b4449a5dd5ddfa5bf784cf. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from c26049db4009fde9b0b4449a5dd5ddfa5bf784cf. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️profiles/2020-09-01/compute/mgmt/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2021-03-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `Sku` in struct `VirtualMachineScaleSetPublicIPAddressConfiguration`
info	[Changelog] - New field `DeleteOption` in struct `VirtualMachineScaleSetNetworkConfigurationProperties`
info	[Changelog] - New field `DeleteOption` in struct `VirtualMachineScaleSetPublicIPAddressConfigurationProperties`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 53 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2020-12-01/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2020-06-30/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `GroupByUserAgent` in struct `LogAnalyticsInputBase`
info	[Changelog] - New field `GroupByClientApplicationID` in struct `ThrottledRequestsInput`
info	[Changelog] - New field `GroupByUserAgent` in struct `ThrottledRequestsInput`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2020-06-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
info	[Changelog] - New field `GroupByClientApplicationID` in struct `RequestRateByIntervalInput`
info	[Changelog] - New field `GroupByUserAgent` in struct `RequestRateByIntervalInput`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2019-12-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2019-07-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2019-03-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2018-10-01/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-06-01/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-04-01/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-12-01/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-09-01/skus [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-03-30/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2016-03-30/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2015-06-15/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2020-10-01-preview/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2016-04-30-preview/compute [View full logs]  [Preview SDK Changes] 
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from c26049db4009fde9b0b4449a5dd5ddfa5bf784cf. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/compute/resource-manager/readme.md
    • ️✔️@azure/arm-compute [View full logs]  [Preview SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/computeManagementClient.js → ./dist/arm-compute.js...
cmderr	[npmPack] created ./dist/arm-compute.js in 1.6s
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from c26049db4009fde9b0b4449a5dd5ddfa5bf784cf. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model VirtualMachineScaleSetUpdateNetworkConfiguration has a new parameter delete_option
info	[Changelog]   - Model VirtualMachineScaleSetUpdateNetworkProfile has a new parameter network_api_version
info	[Changelog]   - Model VirtualMachineScaleSetNetworkConfiguration has a new parameter delete_option
info	[Changelog]   - Model VirtualMachineScaleSetPublicIPAddressConfiguration has a new parameter delete_option
info	[Changelog]   - Model VirtualMachineScaleSetPublicIPAddressConfiguration has a new parameter sku
info	[Changelog]   - Model NetworkInterfaceReference has a new parameter delete_option
info	[Changelog]   - Model VirtualMachineScaleSetUpdatePublicIPAddressConfiguration has a new parameter delete_option
info	[Changelog]   - Model VirtualMachineScaleSetNetworkProfile has a new parameter network_api_version
info	[Changelog]   - Model NetworkProfile has a new parameter network_interface_configurations
info	[Changelog]   - Model NetworkProfile has a new parameter network_api_version
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model PurchasePlan no longer has parameter promotion_code
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from c26049db4009fde9b0b4449a5dd5ddfa5bf784cf. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Compute [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Compute label Mar 16, 2021
    @openapi-workflow-bot
    Copy link

    Hi @basharg, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    This was referenced Mar 16, 2021
    Draft
    Draft
    Draft
    Draft
    Draft
    szimmer-dev
    szimmer-dev reviewed Mar 16, 2021
    View reviewed changes
    specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json Outdated Show resolved Hide resolved
    specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json Show resolved Hide resolved
    specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json Outdated Show resolved Hide resolved
    specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json Outdated Show resolved Hide resolved
    specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json Outdated
    "deleteOption": {
    "type": "string",
    "description": "Specify what happens to the public IP address when the VM is deleted",
    "default": "Delete",
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    What do these defaults do?

    Should this default to delete or null, what is best practice here?

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    for VM with profile config, shouldn't the default be Delete?

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The default is delete on the server side.

    In terms of client libraries I am not sure of the best practice, we should perhaps ask Adam and Jun

    specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json Outdated Show resolved Hide resolved
    specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json Outdated Show resolved Hide resolved
    specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json Outdated Show resolved Hide resolved
    specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json Outdated
    },
    "deleteOption": {
    "type": "string",
    "default": "Delete",
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Should the default be delete or null here as above

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    default as delete for VM?

    specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json Outdated Show resolved Hide resolved
    @ArcturusZhang
    Copy link
    Member

    Breaking changes reported in this PR are all accumulated from previous PRs, therefore those are fine to ignore

    @Sandido
    Copy link
    Member

    Sandido commented Apr 9, 2021

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @msyyc
    Copy link
    Member

    msyyc commented Apr 12, 2021

    The breaking changes for python are accumulated from previous PRs.

    @Sandido
    Copy link
    Member

    Sandido commented Apr 12, 2021

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @openapi-workflow-bot
    Copy link

    Hi, @basharg your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @yungezz

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 12, 2021
    @majastrz majastrz added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMRevisit and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 14, 2021
    @j5lim j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Apr 20, 2021
    @yungezz
    Copy link
    Member

    yungezz commented Apr 22, 2021

    hi @basharg, @Sandido is this PR ready to merge?

    @szimmer-dev szimmer-dev mentioned this pull request Apr 23, 2021
    Closed
    @Sandido Sandido merged commit ed04d18 into Azure:compute-2021-03 Apr 23, 2021
    @szimmer-dev szimmer-dev mentioned this pull request Apr 23, 2021
    Closed
    @Sandido Sandido mentioned this pull request Apr 26, 2021
    Closed
    26 tasks
    @Sandido Sandido mentioned this pull request May 5, 2021
    Merged
    26 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @majastrz majastrz majastrz left review comments

    @Sandido Sandido Sandido approved these changes

    @szimmer-dev szimmer-dev szimmer-dev approved these changes

    @yungezz yungezz yungezz approved these changes

    @dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms

    @grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore

    @haagha haagha Awaiting requested review from haagha

    @hyonholee hyonholee Awaiting requested review from hyonholee

    @madewithsmiles madewithsmiles Awaiting requested review from madewithsmiles

    @MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs

    Assignees

    @yungezz yungezz

    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go Compute
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    8 participants
    @basharg @Sandido @ArcturusZhang @msyyc @yungezz @szimmer-dev @majastrz @j5lim