[Compute] Add disk-encryption-set command group #11411
Conversation
| # region disk encryption set | ||
| with self.argument_context('disk-encryption-set create') as c: | ||
| c.argument('disk_encryption_set_name', name_arg_type, help='Name of disk encryption set.') | ||
| c.argument('key_url', help='URL pointing to a key or secret in KeyVault.') |
There was a problem hiding this comment.
is the key_url same with Swagger property name? it's confusing with help message.
There was a problem hiding this comment.
is the key_url same with Swagger property name? it's confusing with help message.
Yes.
e.g. https://vault4848.vault.azure.net/keys/key1/e3a5735dfa4d47b8879fa61cdd1cfb82
There was a problem hiding this comment.
Maybe the name --key or --active-key is better than --key-url.
src/azure-cli/azure/cli/command_modules/vm/_template_builder.py
Outdated
Show resolved
Hide resolved
| @@ -100,6 +100,21 @@ | |||
| crafted: true | |||
| """ | |||
|
|
|||
| helps['disk-encryption-set'] = """ | |||
| type: group | |||
| short-summary: Disk Encryption Set resource. | |||
There was a problem hiding this comment.
@ramankumarlive, could you help give a summary of disk encryption set?
| @@ -172,6 +173,11 @@ def load_command_table(self, _): | |||
| client_factory=cf_log_analytics_data_plane, | |||
| ) | |||
|
|
|||
| compute_disk_encryption_set_sdk = CliCommandType( | |||
| operations_tmpl='azure.mgmt.compute.operations#DiskEncryptionSetsOperations.{}', | |||
| client_factory=cf_disk_encryption_set | |||
There was a problem hiding this comment.
actually, I'm curious about the api-version of this command type. Sometimes you need to set operation_group for the commandType in VM, sometimes you don't. Is there any guideline for this?
There was a problem hiding this comment.
operation_group - Only used by the azure-cli-vm module to specify which resource API to target. No
Issue #10948
Added
disk-encryption-set create,disk-encryption-set show,disk-encryption-set list,disk-encryption-set delete,disk-encryption-set updateAdded
--encryption-typeand--disk-encryption-settodisk createAdded
--os-disk-encryption-setand--data-disk-encryption-setstovm createAdded
--os-disk-encryption-setand--data-disk-encryption-setstovmss createThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.