Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Profile} Fix cloud endpoint not set error #14664

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

fengzhou-msft
Copy link
Member

@fengzhou-msft fengzhou-msft commented Aug 5, 2020

Description

Fix #14309
Not all clouds have all the cloud endpoints, the previous code may throw endpoint is not set but is used error.

Testing Guide

For local tests, you can simply set the sql_management to None for AzureCloud in cloud.py and run az ad sp create-for-rbac. Without this PR, you will see the error described in #14309. After this PR, the error is gone.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 5, 2020

Profile

@jiasli
Copy link
Member

jiasli commented Aug 6, 2020

It will be great to add some description and testing guide.

@fengzhou-msft fengzhou-msft merged commit 58c9f78 into Azure:dev Aug 6, 2020
@fengzhou-msft fengzhou-msft added this to the S174 milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql_management endpoint not set error while trying to create service principal against azurestack
4 participants