{Identity} Add back get_msal_token #16596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzhou-msft
requested review from
evelyn-ys,
houk-ms,
jiasli,
jsntcy and
Juliehzl
as code owners
|
@jiasli for awareness |
|
We can ignore those Linux builds as we are releasing via |
jiasli
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The get_msal_token method was added with a hack to use adal refresh token to get msal ssh cert for vm ssh feature used in the ssh extension.
This PR adds back a
get_msal_tokenmethod with the same interface for backward compatibility, but useazure-identityto fetch the ssh cert.Testing Guide
Create a Ubuntu vm on portal and remember to enable system assigned identity and AAD login in the management tab.
Assign a
Virtual Machine Administrator LoginorVirtual Machine UserLogin roleover the vm scope for your account.Run
az ssh vm -g <> --vm-name <>History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.