Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback] Do not minify feedback issue body #17353

Merged
merged 4 commits into from
Apr 9, 2021
Merged

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Mar 18, 2021

(Requires #17324)

Resolve #16386

Context

az feedback opens an GitHub issue by filling the body query parameter. (See About automation for issues and pull requests with query parameters)

https://github.com/azure/azure-cli/issues/new?body={}

Due to the URL length limitation on some legacy web browsers like IE, CLI minifies the issue body (especially call stack) to fit the URL length into the limitation:

This sometimes truncates the call stack has caused us many problems while troubleshooting (#16386).

Modern browsers are already accepting URL length exceeding the old limitation (https://stackoverflow.com/a/417184), so the motivation to minify the error_string is less reasonable.

The minification process is also very error prone (#17301).

Change

This PR

  1. removes the minification logic
  2. tells the user to manually open an issue if the URL exceeds the browser or GitHub's limitation

Testing Guide

  1. Place raise Exception after
    def signed_session(self, session=None): # pylint: disable=arguments-differ
  2. Run az group list to trigger a very long error stack
  3. Run az feedback

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 18, 2021

Feedback

@yonzhan yonzhan added this to the S185 milestone Mar 18, 2021
@jiasli jiasli marked this pull request as ready for review March 19, 2021 09:13
# Conflicts:
#	src/azure-cli/azure/cli/command_modules/feedback/custom.py
@jiasli jiasli merged commit 9f0f0d2 into Azure:dev Apr 9, 2021
@jiasli jiasli deleted the feedback branch April 9, 2021 12:44
@jiasli jiasli mentioned this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

az feedback truncates the call stack
4 participants