[Feedback] Do not minify feedback issue body #17353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Requires #17324)
Resolve #16386
Context
az feedback
opens an GitHub issue by filling thebody
query parameter. (See About automation for issues and pull requests with query parameters)Due to the URL length limitation on some legacy web browsers like IE, CLI minifies the issue body (especially call stack) to fit the URL length into the limitation:
azure-cli/src/azure-cli/azure/cli/command_modules/feedback/custom.py
Line 34 in e3ac647
This sometimes truncates the call stack has caused us many problems while troubleshooting (#16386).
Modern browsers are already accepting URL length exceeding the old limitation (https://stackoverflow.com/a/417184), so the motivation to minify the
error_string
is less reasonable.The minification process is also very error prone (#17301).
Change
This PR
Testing Guide
raise Exception
afterazure-cli/src/azure-cli-core/azure/cli/core/adal_authentication.py
Line 118 in f7fc070
az group list
to trigger a very long error stackaz feedback