[Storage] az storage share-rm: Support create/show/delete snapshots
#17449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
changed the title
az storage share-rm: Support create/show/delete snapshotaz storage share-rm: Support create/show/delete snapshots
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Storage |
Juliehzl
reviewed
Mar 30, 2021
Juliehzl
reviewed
Mar 30, 2021
Juliehzl
reviewed
Mar 30, 2021
| g.generic_update_command('update', setter_name='update', setter_arg_name='file_share', | ||
| custom_func_name='update_share_rm') | ||
| g.custom_command('stats', 'get_stats', transform=lambda x: getattr(x, 'share_usage_bytes')) | ||
| g.custom_command('restore', 'restore_share_rm') | ||
| g.custom_command('snapshot', 'snapshot_share_rm', min_api='2020-08-01-preview', |
There was a problem hiding this comment.
could you add preview tag for new commands?
There was a problem hiding this comment.
Added for new command and new parameter.
Juliehzl
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
File share management plane operations support snapshot CRD. (List operation is not covered in this PR because list including both deleted and snapshots is not supported which is a known issue will be resolved in next api version.)
Related swagger: Azure/azure-rest-api-specs#11372
Testing Guide
Create:
az storage share-rm snapshotShow:
az storage share-rm show --snapshotDelete:
az storage share-rm delete --snapshotThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.