-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Core} Expose public interface for SecretStore
#22372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
zhoxing-ms,
evelyn-ys,
calvinhzy,
jsntcy and
kairu-ms
as code owners
May 12, 2022 10:57
ghost
requested a review
from yonzhan
May 12, 2022 10:57
ghost
assigned jiasli
May 12, 2022
ghost
added this to the May 2022 (2022-05-24) - For Build milestone
May 12, 2022
A good solution for SecretStore |
3 tasks
StrawnSC
approved these changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected when I try with our setup here (caching GitHub credentials for the containerapp
extension). Thanks!
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
evelyn-ys
approved these changes
May 16, 2022
calvinhzy
approved these changes
May 16, 2022
@rayluo, CLI is helping |
rayluo
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose public interface for using encrypted
SecretStore
so that command modules or extensions (such as calvinsID/azure-cli-extensions#97) can leveragemsal-extensions
to save custom data such as tokens.Testing Guide
On Windows:
Turn off token encryption: