Support Python 2.7 again #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,11 +1,11 @@ | |||
| import collections.abc | |||
There was a problem hiding this comment.
I suspect that you should try to import collections.abc and import collections on failure.
|
found one more instance of 2.7 support lacking. Unfortunately a full pass of the product is required to see if 2.7 works or not. Will address soon |
|
@johanste feedback addressed and new scenario converted |
|
@johanste changes should be ready to go, not including Steve on the review since the changes are mostly subtractions |
|
@BurtBiel, you can rebase from the latest master branch, which contains the travis CI integration. This way you can check whether all 2.7 specific issues are addressed. Hope it helps. |
|
LGTM |
derekbekoe
pushed a commit
that referenced
this pull request
Feb 7, 2017
* Add batch data plane commands: -- Add custom commands -- Add auto execution data plane codes -- Import mgmt commands experience * Added file stream support * bug fixes * Fixed regex raw strings * Added support for JSON input * Custom and type validation (#4) * Additional validation and parsing * Some cleanups * Minor code refinements * Fix pylint errors and get rid unused codes. * List and type validation (#5) * list and type validation * Remove auth kwargs * Fixed typo * clean pylint error and add data plane command test. * Bug fixes (#6) * Remove auth kwargs * Bug fixes * Fixed kwargs * Move the update pool command to custom command. * Add custom commands test cases * Tests and delete confirmation (#7) * Added some tests * Bug fixes * Added tests to sln * Delete confirmation * Some pylint cleanup * More tests and fixes (#8) * Fix pylint and test errors. * Following PEP8 complaint. * Use this decroator on doc transfer * Deferred imports for performance (#9) * streamlined imports * pylint fixes * Renamed AzureDataPlaneCommand * PyLint and PEP8 clean up. * Use single parameter for storage account id and name. * Review feedback + help fixes (#10) * node-user -> node user * Review feedback * More feedback fixes * pep fixes * fixed underscore * More touch ups * Review fixes (#11) * Command refinements * More command feedback * Test fixes * More tests * Add enum list for vmsize and thumbprint algorithm. * Streamlined commands (#13) * streamlined commands * Updated tests * Fixed arg loading test * Further command refinements (#14) * support silent args * Fixed pool error message * Further command editing * last fixes * Fixed tests (#15) * Change the coding style.
vishrutshah
added a commit
that referenced
this pull request
Mar 21, 2017
… plane (#2534) * Adding basic structure for monitor service * Adding list command for all azure monitor data plane * Adding help docs for az monitor data plane commands * Adding commands for management place of Azure monitor service * Updating azure-monitor-cli to azure-mgmt-monitor and azure-monitor sdk * Using nargs to input list of metric-names * Implement filter for metrics list command * Implement filter and select in activity-logs command * Implement filter and select for tenant-activity-logs command * Adding scaffold command in autoscale-settings (#4) * Adding unittests for custom monitor commands (#5) * Rename expanded params and resolve bugs * Fix expand parameters bug in util to support any parameters * Adding --filters into activity-logs & tenant-activity-logs * Adding --ids support into alert-rules & autoscale-settings' show and delete commands * ignoring filter for alert-rules and autoscale-settings list * Help docs for all monitor commands to review * rename activity-logs to activity-log * Removing tenant-activity-logs command * Removing event-categories commands as less useful * Update version to 0.0.1b1+dev * Renamed service-dignostic-settings to diagnostic-settings * update help for review * Update unittests for filters * Renaming parameter_abc into parameter * marking metric-names as required parameter for metrics list * Removing help.json from the review
WiseMack
added a commit
to WiseMack/azure-cli
that referenced
this pull request
Jan 17, 2019
jseely
added a commit
to jseely/azure-cli
that referenced
this pull request
Sep 26, 2019
Currently the Azure CLI does not work in environments without public internet access when trying to use the managed disk image in Azure#5 of the _parse_image_argument function. This fix ignores the ConnectionError in Azure#4 when trying to lookup the aliases doc from `githubusercontent.com` and proceeds to Azure#5. If Azure#5 does not match then it will return the error message: ``` Failed to connect to remote source of image aliases. Invalid image "{}". Use a valid image URN, customer image name, customer image id, or VHD blob URI. See vm create -h for more information on specifying an image. ```
2 tasks
qwordy
pushed a commit
that referenced
this pull request
Oct 10, 2019
…10658) * Continue parsing image argument if aliases doc unreachable Currently the Azure CLI does not work in environments without public internet access when trying to use the managed disk image in #5 of the _parse_image_argument function. This fix ignores the ConnectionError in #4 when trying to lookup the aliases doc from `githubusercontent.com` and proceeds to #5. If #5 does not match then it will return the error message: ``` Failed to connect to remote source of image aliases. Invalid image "{}". Use a valid image URN, customer image name, customer image id, or VHD blob URI. See vm create -h for more information on specifying an image. ``` * Updated to fix Check CLI Style * Don't override global ConnectionError
jiasli
pushed a commit
that referenced
this pull request
Apr 7, 2020
Juliehzl
pushed a commit
to Juliehzl/azure-cli
that referenced
this pull request
Jan 26, 2021
Merge from master repository
Closed
alanenriqueo
pushed a commit
to alanenriqueo/azure-cli
that referenced
this pull request
Oct 18, 2022
Rdbms test location change
jsntcy
added a commit
to wu5bocheng/azure-cli
that referenced
this pull request
Feb 27, 2023
[Add] Add command group `microsoft.storage/storageaccounts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.