-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Adding support for Private DNS Public Preview #5763
Merged
tjprescott
merged 9 commits into
Azure:dev
from
muwaqar:muwaqar/private-dns-public-preview
Mar 15, 2018
Merged
[DNM] Adding support for Private DNS Public Preview #5763
tjprescott
merged 9 commits into
Azure:dev
from
muwaqar:muwaqar/private-dns-public-preview
Mar 15, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View a preview at https://prompt.ws/r/Azure/azure-cli/5763 |
Please do NOT merge the PR until the relevant Swagger and Python SDK PRs have been merged. |
tjprescott
changed the title
Adding support for Private DNS Public Preview
[DNM] Adding support for Private DNS Public Preview
Mar 8, 2018
tjprescott
approved these changes
Mar 8, 2018
@tjprescott : Please have a look at the PR, and if you don't have any comments, then please merge it at your earliest convenience. |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #5757 which accidentally got closed.
This PR adds support for creating/updating Private DNS zones for the public preview release. It is based on the Python SDK PR Azure/azure-sdk-for-net#4109 which in turn is based on Swagger version 2018-03-01-preview Azure/azure-rest-api-specs#2587.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)