-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CosmosException: Adds diagnostics to message for 408, 500, 503, 404/1002 scenarios #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
September 9, 2021 17:50
…azure-cosmos-dotnet-v3 into users/jawilley/exceptions
ealsur
reviewed
Sep 10, 2021
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosException.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Sep 10, 2021
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosException.cs
Outdated
Show resolved
Hide resolved
sourabh1007
previously approved these changes
Sep 10, 2021
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosException.cs
Outdated
Show resolved
Hide resolved
…eption.cs Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
kirankumarkolli
previously approved these changes
Sep 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j82w
changed the title
CosmosException: Adds diagnostics to message for 408, 500, 503 scenarios
CosmosException: Adds diagnostics to message for 408, 500, 503, 404/1002 scenarios
Sep 10, 2021
ealsur
approved these changes
Sep 10, 2021
kirankumarkolli
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This change is being done because most users are not capturing the diagnostics for these exceptions. It is not possible to root cause or trouble shoot these issues without the diagnostics. This requires the customer to make code changes to get the additional info which causes the issue to persist for a long time.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber