Update CosmosHttpClientCore.cs #3044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anstein-msft
requested review from
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
|
|
|
@kirankumarkolli @j82w @ealsur @FabianMeiswinkel @kirillg @sboshra I reviewed my changes with another developer, made some updates, merged in all the recent changes to Cosmos Core. Please let me know if this is something that could get looked at to merge in. |
|
Closing as the original issue is addressed by #3455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding context information to the exception thrown in the HTTP request made to add the User agent, when an invalid character is provided in the ApplicationName string when constructing a CosmosClient.
This will help developers figure out what issue they are dealing with when they provide an application name that is not valid.
Type of change
[] New feature (non-breaking change which adds functionality)
Closing issues
To automatically close an issue: closes #3040