Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch: Adds Null support for Set operation #3093

Merged
merged 10 commits into from
Apr 7, 2022
Merged

Patch: Adds Null support for Set operation #3093

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b194956
Null exception removed in Patch operation Set
SchintaMicrosoft Mar 17, 2022
8d2d9c3
Comment Removed.
SchintaMicrosoft Mar 18, 2022
85b43d6
Merge branch 'master' into users/schinta/2931
j82w Mar 21, 2022
9f7e630
Merge branch 'master' into users/schinta/2931
j82w Mar 22, 2022
386a4d5
Merge branch 'master' into users/schinta/2931
j82w Mar 22, 2022
70d8656
Added PatchOperationTests.
SchintaMicrosoft Mar 31, 2022
bd76a33
Merge branch 'users/schinta/2931' of https://github.com/Azure/azure-c…
SchintaMicrosoft Mar 31, 2022
9ec362b
Tests updated with directly null value
SchintaMicrosoft Apr 7, 2022
b130047
Generic type updated string to object
SchintaMicrosoft Apr 7, 2022
032739a
Merge branch 'master' into users/schinta/2931
j82w Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Microsoft.Azure.Cosmos/src/Patch/PatchOperationCore{T}.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public PatchOperationCore(
this.Path = string.IsNullOrWhiteSpace(path)
? throw new ArgumentNullException(nameof(path))
: path;
this.Value = value ?? throw new ArgumentNullException(nameof(value));
this.Value = value;
}

public override T Value { get; }
Expand Down
4 changes: 4 additions & 0 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/PatchOperationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ public void ConstructPatchOperationTest()
Guid guid = new Guid();
operation = PatchOperation.Set(path, guid);
PatchOperationTests.ValidateOperations(operation, PatchOperationType.Set, guid);

string value = null;
operation = PatchOperation.Set(path, value);
PatchOperationTests.ValidateOperations(operation, PatchOperationType.Set, value);
j82w marked this conversation as resolved.
Show resolved Hide resolved
}

private static void ValidateOperations<T>(PatchOperation patchOperation, PatchOperationType operationType, T value)
Expand Down