Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Telemetry And Diagnostics : Adds VMId or Unique Id in payload #3100

Merged
merged 29 commits into from
Apr 7, 2022

Conversation

sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Mar 21, 2022

Description

  1. Add machineId information in client telemetry payload and request diagnostics.
    a) For Azure Instance : it will be vmId from Azure Instance Metadata API call with prefix vmId:
    b) Otherwise:
    i) It will have hashedMachineId: + <hashedMachineName>
    ii) If it throws exception, uuid: <generated uuid>
  2. No retry policy for VM Metadata API call, till now Default Policy were retrying if call fails.
  3. No retry policy for Client Telemetry API call.

Use Cases for Client Telemetry:

a) Helpful to identify if any particular machine is having issue.
b) We can corelate this information with Compute Kusto/Networking Team (any other team outside cosmos db sdk)

Use Cases for Request Diagnostics:

a) In case of vmid, We can corelate this information with Compute Kusto/Networking Team (any other team outside cosmos db sdk)
b) It will be helpful to identify if all the requests are coming from same machine or different machine. (if cx provides bunch of request diagnostics)
c) In case of uuid, this information won't be helpful much.

For Azure Instance:

Client Telemetry

image

Request Diagnostics

image

For Non-Azure Instance:

Client Telemetry

image

Request Diagnostics

image

Client Telemetry

image

Request Diagnostics

image

Type of change

  • [] New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #3096

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vmId should be added to request diagnostics as well

@sourabh1007 sourabh1007 changed the title Client Telemetry: Adds VMId or Unique Id in payload Client Telemetry And Diagnostics : Adds VMId or Unique Id in payload Mar 22, 2022
ealsur
ealsur previously approved these changes Mar 23, 2022
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/ctvmid branch 2 times, most recently from dc6e836 to 79f2c1f Compare March 25, 2022 22:15
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for few small comments

@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/ctvmid branch 3 times, most recently from f435120 to 895ceeb Compare April 1, 2022 21:26
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@j82w j82w merged commit 87f86f8 into master Apr 7, 2022
@j82w j82w deleted the users/sourabhjain/ctvmid branch April 7, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Telemetry : Adds Machine Id or VM Id for a process
4 participants