[Internal] PartitionMerge: Adds SDKSupportedCapabilities to hint that SDK supports merge #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_14 to indicate merge support (Azure#3015)" This reverts commit 83d4d0c.
ramarag
requested review from
kirillg,
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel and
sboshra
as code owners
kirankumarkolli
previously approved these changes
Mar 22, 2022
j82w
reviewed
Mar 22, 2022
j82w
reviewed
Mar 22, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/ContractTests.cs
Show resolved
Hide resolved
ealsur
reviewed
Mar 22, 2022
j82w
reviewed
Mar 24, 2022
ealsur
reviewed
Mar 24, 2022
ramarag
force-pushed
the
users/ramarag/addMergeSDKSupportedCapabilities
branch
from
8e09505
to
ce8cc01
Compare
ealsur
previously approved these changes
Mar 24, 2022
j82w
previously approved these changes
Mar 24, 2022
j82w
reviewed
Mar 24, 2022
ramarag
force-pushed
the
users/ramarag/addMergeSDKSupportedCapabilities
branch
from
e338259
to
8f996f1
Compare
ramarag
force-pushed
the
users/ramarag/addMergeSDKSupportedCapabilities
branch
from
8f996f1
to
947737c
Compare
j82w
approved these changes
Mar 24, 2022
ealsur
approved these changes
Mar 24, 2022
j82w
changed the title
6 tasks
ramarag
commented
Apr 7, 2022
| @@ -112,7 +112,7 @@ static CosmosClient() | |||
| #if PREVIEW | |||
| HttpConstants.Versions.CurrentVersion = HttpConstants.Versions.v2020_07_15; | |||
| #else | |||
| HttpConstants.Versions.CurrentVersion = HttpConstants.Versions.v2019_10_14; | |||
| HttpConstants.Versions.CurrentVersion = HttpConstants.Versions.v2018_12_31; | |||
There was a problem hiding this comment.
changing the API version back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR: #3015, we attempted to use v2019_10_14 as the minimum API version to indicate to CosmosDB service that the SDK is merge proof. Unfortunately, Java SDK had already introduced a higher API version v2020_07_15 (https://github.com/Azure/azure-sdk-for-java/blob/d70090131c407a57a75d1cafeb0dcef566a48315/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/HttpConstants.java#L285), without having the support for merge.
This will break the check in the backend to use API version to determine if merge support is present in the SDK
In this PR we are introducing SDKSupportedCapabilities, a header is passed to backend to indicate the merge support has been added.
We still plan to block sdks that do not have support when partition merge feature will be turned on in the service.