Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserAgent: Removes direct version #3173

Merged
merged 4 commits into from
May 5, 2022

Conversation

imanvt
Copy link
Contributor

@imanvt imanvt commented May 5, 2022

Pull Request Template

Description

Remove direct version from user agent to as it is unnecessary. The direct version dll is copied into the nuget folder rather than being referenced as a nuget so customers can not change it.

Type of change

  • New feature (non-breaking change which adds functionality)

Closing issues

closes #3160

@imanvt imanvt linked an issue May 5, 2022 that may be closed by this pull request
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@imanvt imanvt changed the title Remove direct version from user agent UserAgent: Removes direct version May 5, 2022
@github-actions github-actions bot dismissed their stale review May 5, 2022 16:22

All good!

@imanvt imanvt marked this pull request as ready for review May 5, 2022 18:40
@j82w j82w merged commit b04468c into master May 5, 2022
@j82w j82w deleted the users/imanvt/3160-useragent-remove-direct-version branch May 5, 2022 19:47
@sourabh1007
Copy link
Contributor

sourabh1007 commented May 9, 2022

Now onwards..what is the right way to check which version of SDK is using which version of Direct package?

@j82w @imanvt

@j82w
Copy link
Contributor

j82w commented May 9, 2022

The user agent still has the SDK version. The direct version can be found by looking it up in the github branches. There is a branch for every release.

@sourabh1007
Copy link
Contributor

The user agent still has the SDK version. The direct version can be found by looking it up in the github branches. There is a branch for every release.

Should we make it part of our changelog? that will make life easier instead of searching for it in the branch

@j82w
Copy link
Contributor

j82w commented May 9, 2022

It's very rare that we need to know the direct version. I don't think we need to log it in the changelog, and it's not something customer should know or care about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserAgent: Remove direct version
3 participants