New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Preview] Change Feed: Adds SDK changes required for Full-Fidelity Change Feed #3197

Merged

kirankumarkolli merged 40 commits into master from users/philipthomas/fullfidelitycfp

Aug 1, 2022

Contributor

philipthomas-MSFT commented May 16, 2022 •

edited

Loading

Pull Request Template

Description

SDK changes required for Full-Fidelity Change Feed.

Type of change

Supports new ItemChanges<> type to be used by the FeedIterator that contains Metadata
Supports default UseGatewayMode to true on request if Full-Fidelity change feed
Supports default wire format on Full-Fidelity that includes metadata

Closing issues

To automatically close an issue: closes #IssueNumber

philipthomas-MSFT requested review from khdang, sboshra, neildsh, kirankumarkolli, j82w, ealsur, FabianMeiswinkel and kirillg as code owners

May 16, 2022 22:16

github-actions bot requested changes

View reviewed changes

github-actions bot left a comment

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedModeFullFidelity.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedModeFullFidelity.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedModeFullFidelity.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedMode.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Handler/RequestMessage.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Microsoft.Azure.Cosmos.csproj Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedItem{T}.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedItem{T}.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/Metadata.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/OperationType.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedItem{T}.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/Response.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Serializer/CosmosSerializerCore.cs Outdated Show resolved Hide resolved

ealsur reviewed

View reviewed changes

Member

ealsur left a comment

See comments

kirankumarkolli reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedItem{T}.cs Outdated Show resolved Hide resolved

kirankumarkolli reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/Metadata.cs Outdated Show resolved Hide resolved

kirankumarkolli reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/Metadata.cs Outdated Show resolved Hide resolved

kirankumarkolli reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/OperationType.cs Outdated Show resolved Hide resolved

Contributor

sourabh1007 commented May 17, 2022

Pull Request Template

Description

SDK changes required for Full-Fidelity Change Feed.

Type of change

ChangeFeedItem<> contains Metadata

Default UseGatewayMode to true on request if Full-Fidelity

Default wire format on Full-Fidelity

Closing issues

To automatically close an issue: closes #IssueNumber

Can you please describe little bit more about Full fidelity Change Feed. What does it mean actually?
for "Type of change" section you should have selected from the options given in the template.

sourabh1007 reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Handler/RequestMessage.cs Outdated Show resolved Hide resolved

philipthomas-MSFT changed the title ~~SDK changes required for Full-Fidelity Change Feed from Users/philipthomas/fullfidelitycfp~~ [Public] Adds SDK changes required for Full-Fidelity Change Feed from Users/philipthomas/fullfidelitycfp

philipthomas-MSFT added 2 commits

June 22, 2022 08:51


          Merge branch 'users/philipthomas/fullfidelitycfp' of https://github.c…

884068a

…om/Azure/azure-cosmos-dotnet-v3 into users/philipthomas/fullfidelitycfp


          re-running UpdateContracts.ps1 for the LogSequenceNumber change from …

146196b

…CurrentLogSequenceNumber

simorenoh mentioned this pull request

[Cosmos] [Preview] Full-Fidelity Change Feed Azure/azure-sdk-for-java#29799

Closed


          Merge branch 'master' into users/philipthomas/fullfidelitycfp

1d2da2b

philipthomas-MSFT requested a review from adityasa as a code owner

July 26, 2022 15:14

ealsur previously approved these changes

View reviewed changes

kushagraThapar mentioned this pull request

[Cosmos] Full Fidelity Change Feed changes for pull model Azure/azure-sdk-for-java#30161

Merged


          fixed a test because of the emulator change to include deleted operat…

364f913

…ions in FFCF metadata

philipthomas-MSFT dismissed ealsur’s stale review via

364f913

July 28, 2022 14:16

philipthomas-MSFT requested review from sourabh1007, FabianMeiswinkel, ealsur, kushagraThapar and simorenoh

July 28, 2022 16:24


          Merge branch 'master' into users/philipthomas/fullfidelitycfp

4f33d82

sourabh1007 previously approved these changes

View reviewed changes

kirankumarkolli reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedItemChanges{T}.cs Outdated Show resolved Hide resolved

kirankumarkolli reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedItemChanges{T}.cs Outdated Show resolved Hide resolved

kirankumarkolli reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedMetadata.cs Show resolved Hide resolved

kirankumarkolli reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedMetadata.cs Outdated Show resolved Hide resolved

philipthomas-MSFT added 2 commits

July 28, 2022 15:37


          Changed ChangeFeedItemChanges to singluar

11d48f1


          Merge branch 'users/philipthomas/fullfidelitycfp' of https://github.c…

c9cbd95

…om/Azure/azure-cosmos-dotnet-v3 into users/philipthomas/fullfidelitycfp

philipthomas-MSFT dismissed sourabh1007’s stale review via

c9cbd95

July 28, 2022 19:37


          renaming to Lsn

2102b7b

philipthomas-MSFT requested review from kirankumarkolli and sourabh1007

July 30, 2022 21:18

sourabh1007 approved these changes

View reviewed changes

kirankumarkolli approved these changes

View reviewed changes

kirankumarkolli merged commit e7dddbb into master

kirankumarkolli deleted the users/philipthomas/fullfidelitycfp branch

August 1, 2022 18:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

koltachev koltachev left review comments

sourabh1007 sourabh1007 approved these changes

kirankumarkolli kirankumarkolli approved these changes

j82w j82w left review comments

GitHub Actions GitHub Actions left review comments

khdang Awaiting requested review from khdang khdang is a code owner

sboshra Awaiting requested review from sboshra sboshra is a code owner

neildsh Awaiting requested review from neildsh neildsh is a code owner

kirillg Awaiting requested review from kirillg kirillg is a code owner

leminh98 Awaiting requested review from leminh98

mkolt Awaiting requested review from mkolt

DmitriMelnikov Awaiting requested review from DmitriMelnikov

adityasa Awaiting requested review from adityasa adityasa is a code owner

FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

ealsur Awaiting requested review from ealsur

kushagraThapar Awaiting requested review from kushagraThapar

simorenoh Awaiting requested review from simorenoh

Labels

None yet