Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeedRange: Fixes a NullRef in FeedRangePartitionKey.ToString() #3480

Merged

Conversation

ramarag
Copy link
Contributor

@ramarag ramarag commented Sep 30, 2022

Pull Request Template

Description

FeedRangePartitionKey.ToString() results in a Null Ref Exception if we give PartitionKey.None
This change checks for PartitionKey.None and returns a valid string. The ToString is used for internal tracing
The issue surfaces when we try to do a ReadFeed with PartitionKey.None

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)

@ramarag ramarag force-pushed the users/ramarag/fixReadFeedOfFixedCollection branch from 4dd6898 to a056ea1 Compare September 30, 2022 06:53
@ealsur ealsur changed the title [MigratedFixedCollection] Fix a NullRef in FeedRangePartitionKey.ToString() FeedRange: Fixes a NullRef in FeedRangePartitionKey.ToString() Sep 30, 2022
@ramarag ramarag force-pushed the users/ramarag/fixReadFeedOfFixedCollection branch from a056ea1 to 84c111f Compare October 3, 2022 16:48
@ealsur ealsur enabled auto-merge (squash) October 3, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants