Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalEndpointManager: Fixes Unobserved and Unhandled Exception from Getting Thrown #4241

Conversation

kundadebdatta
Copy link
Member

@kundadebdatta kundadebdatta commented Jan 9, 2024

Pull Request Template

Description

  • This PR adds a catch block within the RefreshDatabaseAccountInternalAsync method to log unobserved exception instead of throwing them.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #3994

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kundadebdatta kundadebdatta added the auto-merge Enables automation to merge PRs label Jan 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 83958bb into master Jan 31, 2024
20 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/kundadebdatta/3994_fix_unhandled_exception_in_endpoint_manager branch January 31, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
Status: Done
4 participants