Emulator : Adds support for flag in connection string to ignore SSL check #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
2 tasks
Pilchie
reviewed
Jan 16, 2024
sourabh1007
force-pushed
the
users/sourabhjain/readignorecertflag
branch
2 times, most recently
from
5283481
to
ba7027f
Compare
sourabh1007
requested review from
a team,
khdang,
adityasa and
neildsh
as code owners
ealsur
reviewed
Jan 17, 2024
sourabh1007
force-pushed
the
users/sourabhjain/readignorecertflag
branch
2 times, most recently
from
4d81ec3
to
6e8379f
Compare
ealsur
reviewed
Jan 18, 2024
ealsur
reviewed
Jan 18, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosClientOptionsUnitTests.cs
Show resolved
Hide resolved
ealsur
reviewed
Jan 18, 2024
ealsur
previously approved these changes
Jan 18, 2024
sourabh1007
changed the title
sourabh1007
force-pushed
the
users/sourabhjain/readignorecertflag
branch
from
fd9b816
to
e552297
Compare
Co-authored-by: Kiran Kumar Kolli <kirankk@microsoft.com>
Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
sourabh1007
force-pushed
the
users/sourabhjain/readignorecertflag
branch
from
bf239fc
to
c2c3438
Compare
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosClientOptionsUnitTests.cs
Show resolved
Hide resolved
sourabh1007
force-pushed
the
users/sourabhjain/readignorecertflag
branch
from
9c6db2e
to
4f4cc28
Compare
kirankumarkolli
approved these changes
Jan 22, 2024
ealsur
approved these changes
Jan 24, 2024
microsoft-github-policy-service
bot
deleted the
users/sourabhjain/readignorecertflag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add code to read
IgnoreEndpointCertificateflag from connection string to ignore SSL certificate check in SDK. It is useful for local development with emulator.It is not recommended to use this in production account.
Customers who are using
HttpClientFactory, still needs to use the work around.Type of change
Closing issues
To automatically close an issue: closes #4222