DisableServerCertificateValidation: Fixes Default HttpClient to honor DisableServerCertificateValidation #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirankumarkolli
requested review from
khdang,
sboshra,
adityasa,
neildsh,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kirankumarkolli
commented
Feb 1, 2024
kirankumarkolli
changed the title
kirankumarkolli
changed the title
ealsur
reviewed
Feb 1, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Feb 1, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientTests.cs
Outdated
Show resolved
Hide resolved
… and DocumentClient use a consistency way
…on and ServerCertificateCustomValidationCallback combination - Supporting test hook for DisableServerCertificateValidationInvocationCallback (specifically for only Disable checking)
kirankumarkolli
force-pushed
the
users/kirankk/ssl_disable_server_cert_fix
branch
from
0735a1b
to
f78efff
Compare
philipthomas-MSFT
previously approved these changes
Feb 2, 2024
kirankumarkolli
dismissed stale reviews from FabianMeiswinkel and kundadebdatta
via
495669d
Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
ealsur
reviewed
Feb 2, 2024
ealsur
reviewed
Feb 2, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientTests.cs
Outdated
Show resolved
Hide resolved
ealsur
previously approved these changes
Feb 2, 2024
kirankumarkolli
dismissed stale reviews from FabianMeiswinkel and ealsur
via
0dced98
kundadebdatta
approved these changes
Feb 2, 2024
ealsur
approved these changes
Feb 2, 2024
microsoft-github-policy-service
bot
deleted the
users/kirankk/ssl_disable_server_cert_fix
branch
kundadebdatta
pushed a commit
that referenced
this pull request
Feb 7, 2024
… DisableServerCertificateValidation (#4294) * DisableServerCertificateValidation: Fix ensuring that both HttpClient and DocumentClient use a consistency way * E2E Emulator test coverage * - Supporting the combination of both DisableServerCertificateValidation and ServerCertificateCustomValidationCallback combination - Supporting test hook for DisableServerCertificateValidationInvocationCallback (specifically for only Disable checking) * Addressing comments * Fixing a warning * Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com> * Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com> * Addressing commens * Undoing a change * Fixing UT * Renaming a test case name --------- Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
kundadebdatta
pushed a commit
that referenced
this pull request
Feb 7, 2024
… DisableServerCertificateValidation (#4294) * DisableServerCertificateValidation: Fix ensuring that both HttpClient and DocumentClient use a consistency way * E2E Emulator test coverage * - Supporting the combination of both DisableServerCertificateValidation and ServerCertificateCustomValidationCallback combination - Supporting test hook for DisableServerCertificateValidationInvocationCallback (specifically for only Disable checking) * Addressing comments * Fixing a warning * Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com> * Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com> * Addressing commens * Undoing a change * Fixing UT * Renaming a test case name --------- Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
DisableServerCertificateValidationis set:ServerCertificateCustomValidationCallbackis conditionally set after validation when ConnectionPolicy is created. But HttpClient is created before ConnectionPolicy creation resulting in the configuration getting ignored.changes
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber