-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed Tracing: Refactors code to rename net.peer.name attribute to server.address #4316
Merged
microsoft-github-policy-service
merged 9 commits into
master
from
users/sourabhjain/dtattributename
Feb 13, 2024
Merged
Distributed Tracing: Refactors code to rename net.peer.name attribute to server.address #4316
microsoft-github-policy-service
merged 9 commits into
master
from
users/sourabhjain/dtattributename
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
February 8, 2024 02:22
jcocchi
reviewed
Feb 8, 2024
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryRecorderFactory.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Feb 9, 2024
sourabh1007
changed the title
Distributed Tracing: Adds feature as stable and rename Net.Peer,Name attribute
Distributed Tracing: Refactors code to rename Net.Peer,Name attribute
Feb 11, 2024
sourabh1007
changed the title
Distributed Tracing: Refactors code to rename Net.Peer,Name attribute
Distributed Tracing: Refactors code to rename Net.Peer.Name attribute to server.address
Feb 12, 2024
sourabh1007
changed the title
Distributed Tracing: Refactors code to rename Net.Peer.Name attribute to server.address
Distributed Tracing: Refactors code to rename net.peer.name attribute to server.address
Feb 12, 2024
kirankumarkolli
previously approved these changes
Feb 12, 2024
kirankumarkolli
approved these changes
Feb 13, 2024
ealsur
approved these changes
Feb 13, 2024
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryRecorderFactory.cs
Show resolved
Hide resolved
jcocchi
reviewed
Feb 13, 2024
...torTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml
Show resolved
Hide resolved
microsoft-github-policy-service
bot
deleted the
users/sourabhjain/dtattributename
branch
February 13, 2024 16:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renaming
net.peer.name
toserver.address
ref. #4309Type of change
Closing issues
To automatically close an issue: closes #4309