-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChangeFeedProcessor: Adds AllVersionsAndDeletes support to ChangeFeedProcessor #4370
ChangeFeedProcessor: Adds AllVersionsAndDeletes support to ChangeFeedProcessor #4370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the naming has been discussed before and was agreed-upon - LGTM
Much appreciated Fabian. I will make a note to bring other SDK and Principals in on these discussions if necessary moving forward. |
Necessary to run these locally.
Both and Custom encryption container has throw new NotImplementedException. After build and merged, custom encryption container can have the actual implementation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Template
Description
Adding AllVersionsAndDeletes to
ChangeFeedProcessor
.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber