Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK 3.39.0: Adds version bump and changelog. #4391

Conversation

philipthomas-MSFT
Copy link
Contributor

@philipthomas-MSFT philipthomas-MSFT commented Apr 5, 2024

Pull Request Template

Description

This bumps the SDK GA version from 3.38.1 to 3.39.0 and preview version from 3.39.0-preview.1 to 3.40.0-preview.0. Please see the below changes in the GA public contract.

diff API_3_39_0

Also highlighted below are the preview contract changes.

diff API_3 40 0-preview 0

[Note: To understand about the GA and preview versions styles, please take a look at our versioning guidelines and principles]

Directory.Build.props Outdated Show resolved Hide resolved
@kirankumarkolli
Copy link
Member

Are contracts changes upto date?

The images above shows some contracts/APIs are deleted right? Is that expected?

@philipthomas-MSFT
Copy link
Contributor Author

Are contracts changes upto date?

The images above shows some contracts/APIs are deleted right? Is that expected?

I should have checked this. Thanks for pointing it out.

@Maya-Painter
Copy link
Contributor

The changelog doesn't seem to include any query changes - is this intentional?

@philipthomas-MSFT philipthomas-MSFT changed the title SDK 3.38.2: Adds version bump and changelog. SDK 3.39.0: Adds version bump and changelog. Apr 8, 2024
@philipthomas-MSFT
Copy link
Contributor Author

The changelog doesn't seem to include any query changes - is this intentional?

Query PRs have been added. Thanks.

changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
adityasa
adityasa previously approved these changes Apr 8, 2024
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@NaluTripician NaluTripician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably be good to include that the new Taiwan regions are included in Regions.cs with the Direct Package upgrade in the changelog

@philipthomas-MSFT
Copy link
Contributor Author

Would probably be good to include that the new Taiwan regions are included in Regions.cs with the Direct Package upgrade in the changelog

I can agree with that. The PR was Internal. Was that a mistake?
#4386

@NaluTripician
Copy link
Contributor

Would probably be good to include that the new Taiwan regions are included in Regions.cs with the Direct Package upgrade in the changelog

I can agree with that. The PR was Internal. Was that a mistake? #4386

I think normally Direct package upgrades are marked as Internal, but for this upgrade I was unaware of the region changes and that is why it was marked that way. I think we can add something like this to the changelog and link to the direct upgrade PR. Also worth changing our direct upgrade guide to specify this which I will do.

@philipthomas-MSFT
Copy link
Contributor Author

Would probably be good to include that the new Taiwan regions are included in Regions.cs with the Direct Package upgrade in the changelog

I can agree with that. The PR was Internal. Was that a mistake? #4386

I think normally Direct package upgrades are marked as Internal, but for this upgrade I was unaware of the region changes and that is why it was marked that way. I think we can add something like this to the changelog and link to the direct upgrade PR. Also worth changing our direct upgrade guide to specify this which I will do.

Ok. @NaluTripician , added the new regions and direct package version update to the changelog. @kirankumarkolli

NaluTripician
NaluTripician previously approved these changes Apr 9, 2024
sourabh1007
sourabh1007 previously approved these changes Apr 9, 2024
kirankumarkolli
kirankumarkolli previously approved these changes Apr 9, 2024
@kirankumarkolli
Copy link
Member

@ealsur can you please also take a look?

changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 496ddba into master Apr 9, 2024
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/philipthomas-MSFT/prerelease-branch branch April 9, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants