-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Distributed Tracing: Fixes Client Config Test #4408
[Internal] Distributed Tracing: Fixes Client Config Test #4408
Conversation
Lets please port the change from master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please port the master commit
@kirankumarkolli cherry-picked master commit |
PR showing many commits. Can we please create a branch and submit PR? |
Creating new PR. |
Pull request was closed
Description
What is the change?
Added "back", logic to generate activity id, even if customer is not subscribed to any source.
Why is change required?
As part of PR #4333, I removed network level traces generation, along with that, this code was also removed where we were making sure that traceid is generated, even if customer is not subscribed to the any traces.
Why was it not caught in PR pipelines?
It is part of emulator test, and we don't run emulator test in "preview" mode, in our PR pipelines.
Type of change
Closing issues
This would unblock 3.39.0 release